Implementation: map based picker for geospatial point fields

[kanasznagyzoltan]

References

• Fixes Map-based picker for geospatial point fields #5871

Description

Adds a map-based picker for geospatial point metadata fields (e.g. dcterms.spatial), so a WKT POINT(longitude latitude) value can be picked or visually verified on a Leaflet map instead of being typed by hand, on both the submission form and the item metadata editor.

Instructions for Reviewers

List of changes in this PR:

• Added a shared GeospatialMapPickerComponent (src/app/shared/geospatial-map-picker/): a modal Leaflet map that lets a single point be picked (click/drag a marker) or, if the field already has a value, opens centred on that point so it can be verified/corrected. Closes with the resulting WKT string, or null if the point is removed. The plain-text WKT input remains available alongside it.
• Submission form: new geospatial input-type (ParserType.Geospatial / DynamicGeospatialMapModel /
  DsDynamicGeospatialMapComponent), wired into the existing parser/dynamic-form-control pipeline the same way as
  tag/onebox.
• Item metadata editor: new EditMetadataValueFieldType.GEOSPATIAL / DsoEditMetadataGeospatialFieldComponent. The field type is recognised automatically from geospatialMapViewer.spatialMetadataFields (no extra per-field configuration needed beyond what the existing geospatial map viewer already requires).
• Added English and Hungarian translations for the new UI strings.
• Added unit tests for the new parser, the two field components, and the shared picker component.

How to test:

1. Backend: add the geospatial input-type to a metadata field in submission-forms.xml into a form definition you are using for a collection, e.g.:

   <field>
       <dc-schema>dcterms</dc-schema>
       <dc-element>spatial</dc-element>
       <dc-qualifier></dc-qualifier>
       <repeatable>false</repeatable>
       <label>Geospatial point</label>
       <input-type>geospatial</input-type>
       <hint>Click the map button to pick a location, or type a WKT POINT(longitude latitude) value directly.</hint>
       <required></required>
   </field>

2. Frontend config: make sure the field is listed in geospatialMapViewer.spatialMetadataFields, so the item metadata editor also recognises it. The rest of the geospatialMapViewer block isn't required for the picker itself, but enabling it is useful for reviewing the full round-trip (the point you pick showing up on the existing item-page/search map viewer):

   geospatialMapViewer:
     spatialMetadataFields: ['dcterms.spatial']
     spatialFacetDiscoveryConfiguration: 'geospatial'
     spatialPointFilterName: 'point'
     enableItemPageFields: true
     enableBrowseMap: true
     enableSearchViewMode: true
     tileProviders: ['OpenStreetMap.Mapnik']
     defaultCentrePoint: { lat: 47.4979, lng: 19.0402 }

3. Start a new submission in a collection using that submission form. The geospatial field should show a text input plus a map-pin button; clicking it opens the picker. Pick a point and confirm it's saved as a WKT value.
4. Edit an item that already has a value in that field via the item metadata editor (pencil icon on the field row).
   The same map-pin button should appear; opening it should centre the map on the existing point.
5. With enableItemPageFields/enableBrowseMap/enableSearchViewMode enabled, confirm the picked point renders correctly on the item page map / browse-by-map / search "map view".

npm run test:headless (or focus the four new spec files) to run the new unit tests.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[kanasznagyzoltan]

This is a short demo where you can use the map based picker for creating Point values.

map_based_picker_demo_converted.mp4

[github-actions]

Hi @kanasznagyzoltan,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[kanasznagyzoltan]

Updated: merged current main and resolved the conflict.

Upstream has since replaced the hardcoded edit-metadata component map with the generated decorator registry, so the geospatial field component now registers itself via editMetadataValueFieldComponent(EditMetadataValueFieldType.GEOSPATIAL), like the text/entity/authority fields. As a result it also gets lazy loading, and dso-edit-metadata-value-field.decorator.ts no longer needs to be touched at all — the PR is now purely additive.

Unit tests and lint pass locally. There's a short demo video earlier in this thread if anyone wants to see the picker in action without checking out the branch — feedback very welcome.