Add detailed warnings to SSR-related configs about impact on SEO. - #6075
Merged
Conversation
Member
Author
|
Closing & reopening as tests never ran for this PR. |
EikLoe
reviewed
Aug 20, 2026
tdonohue
force-pushed
the
add_ssr_config_warnings
branch
from
August 21, 2026 15:04
f4f9567 to
9b4a9a5
Compare
Member
Author
|
Merging with one approval as this is just code comments. We can always improve further as necessary. |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-6075-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-6075-to-dspace-8_x
git switch --create backport-6075-to-dspace-8_x
git cherry-pick -x 9b4a9a54644cd4255cc939285296c73e921a098f |
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is coming out of a discussion I had with the Google Scholar team today. Google Scholar is still noticing a large number of DSpace sites that are either disabling SSR entirely, or accidentally disabling it on pages that require indexing.
This PR therefore adds inline comments next to the key SSR-related configurations which warn sites about the risk of SEO impacts if they modify the current settings in Production scenarios. This is just an attempt to ensure these warnings are documented at the place(s) where sites might be modifying their configurations...to ensure they don't overlook them.
Instructions for Reviewers