Skip to content

Add detailed warnings to SSR-related configs about impact on SEO. - #6075

Merged
tdonohue merged 1 commit into
DSpace:mainfrom
tdonohue:add_ssr_config_warnings
Aug 21, 2026
Merged

Add detailed warnings to SSR-related configs about impact on SEO.#6075
tdonohue merged 1 commit into
DSpace:mainfrom
tdonohue:add_ssr_config_warnings

Conversation

@tdonohue

@tdonohue tdonohue commented Aug 6, 2026

Copy link
Copy Markdown
Member

Description

This PR is coming out of a discussion I had with the Google Scholar team today. Google Scholar is still noticing a large number of DSpace sites that are either disabling SSR entirely, or accidentally disabling it on pages that require indexing.

This PR therefore adds inline comments next to the key SSR-related configurations which warn sites about the risk of SEO impacts if they modify the current settings in Production scenarios. This is just an attempt to ensure these warnings are documented at the place(s) where sites might be modifying their configurations...to ensure they don't overlook them.

Instructions for Reviewers

  • PR only adds inline comments. No actual code added.
  • Therefore, just review the comments and determine whether they are clearly written or need any updates.

@tdonohue tdonohue added component: SEO Search Engine Optimization configuration 1 APPROVAL pull request only requires a single approval to merge port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release port to dspace-10_x This PR needs to be ported to `dspace-10_x` branch for next bug-fix release labels Aug 6, 2026
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Aug 6, 2026
@tdonohue

Copy link
Copy Markdown
Member Author

Closing & reopening as tests never ran for this PR.

@tdonohue tdonohue closed this Aug 18, 2026
@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to ✅ Done in DSpace 11.0 Release Aug 18, 2026
@tdonohue tdonohue reopened this Aug 18, 2026
@tdonohue tdonohue moved this from ✅ Done to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Aug 18, 2026
Comment thread config/config.example.yml Outdated
@tdonohue
tdonohue force-pushed the add_ssr_config_warnings branch from f4f9567 to 9b4a9a5 Compare August 21, 2026 15:04
@tdonohue
tdonohue requested a review from EikLoe August 21, 2026 15:05

@EikLoe EikLoe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks @tdonohue

@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 11.0 Release Aug 21, 2026
@tdonohue tdonohue added this to the 11.0 milestone Aug 21, 2026
@tdonohue

Copy link
Copy Markdown
Member Author

Merging with one approval as this is just code comments. We can always improve further as necessary.

@tdonohue
tdonohue merged commit 8a63671 into DSpace:main Aug 21, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 11.0 Release Aug 21, 2026
@dspace-bot

Copy link
Copy Markdown
Contributor

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-6075-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-6075-to-dspace-8_x
git switch --create backport-6075-to-dspace-8_x
git cherry-pick -x 9b4a9a54644cd4255cc939285296c73e921a098f

@dspace-bot

Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-9_x:

@dspace-bot

Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-10_x:

@tdonohue tdonohue removed port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release port to dspace-10_x This PR needs to be ported to `dspace-10_x` branch for next bug-fix release labels Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge component: SEO Search Engine Optimization configuration

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants