Skip to content

Fix #5867: Clipped admin sidebar text macOS using firefox - #6118

Open
bram-maegerman wants to merge 1 commit into
DSpace:mainfrom
atmire:w2p-144560_fix-clipped-admin-sidebar-text
Open

Fix #5867: Clipped admin sidebar text macOS using firefox#6118
bram-maegerman wants to merge 1 commit into
DSpace:mainfrom
atmire:w2p-144560_fix-clipped-admin-sidebar-text

Conversation

@bram-maegerman

Copy link
Copy Markdown
Contributor

References

Description

For windows using Firefox, an estimated scrollbar width was already set for the admin-sidebar here. This was not the case yet for macOS.

  • Made sure macOS was recognized when setting the class .browser-{browser name}-{OS name}
  • Added the appropriate width for macOS
  • Added the same width as a default for other OSs, so this shouldn't be an issue anymore in the future.

Instructions for Reviewers

  • Open the admin sidebar (make sure to be logged in as an administrator)
  • Verify the text is now displayed fully next to the icon, instead of partially hidden by the icon.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added bug usability component: administrative tools Related to the admin menu or tools 1 APPROVAL pull request only requires a single approval to merge labels Aug 27, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Aug 27, 2026
@lgeggleston lgeggleston added port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release port to dspace-10_x This PR needs to be ported to `dspace-10_x` branch for next bug-fix release labels Aug 27, 2026

@tinsch tinsch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that these changes fix the original issue 👍 Tested it again on the device where I could reproduce it.
Tested it also in other browsers and on other viewports, looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: administrative tools Related to the admin menu or tools port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release port to dspace-10_x This PR needs to be ported to `dspace-10_x` branch for next bug-fix release usability

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Admin sidebar icons hide part of the label text

3 participants