fix: using new eperson and group on init page instead of cached - #6193
Open
Emil-Domagala-pcg wants to merge 1 commit into
Open
fix: using new eperson and group on init page instead of cached#6193Emil-Domagala-pcg wants to merge 1 commit into
Emil-Domagala-pcg wants to merge 1 commit into
Conversation
Contributor
|
Hi @Emil-Domagala-pcg, thank you for noting and providing a fix for this! Adding to a project board for reviewers to take a look. I've tentatively linked this as fixing #3713 as well - which includes the same issue with editing bitstream policies. However, it outlined the same issue occurring when editing the policy for the item as a whole. So just to check, would this fix apply to editing the item policy as well? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #6192
Fixes #3713 (to be confirmed)
Description
Fix stale group names displayed in the Bitstream Resource Policies table after changing a policy's group.
The resource policy list now explicitly re-requests the linked
epersonandgroupdata instead of using cached versions, ensuring that the table immediately displays the current group information after saving a policy.Instructions for Reviewers
List of changes in this PR:
ResourcePoliciesComponent.initResourcePolicyList()to disable cached versions for theepersonandgrouplinks.reRequestOnStale: trueso that stale linked data is refreshed when loading resource policies.How to test
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the [DSpace BSD License](https://github.com/DSpace/DSpace/blob/main/LICENSE) based on the [Licensing of Contributions](https://wiki.lyrasis.org/display/DSPACE/Code+Contribution+Guidelines#CodeContributionGuidelines-LicensingofContributions) documentation.