fix: avoid undefined community breadcrumb lookup - #6208
Open
dvd233 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #6168
Description
When opening the top-level community creation route, the community breadcrumb resolver is configured with
breadcrumbQueryParam: 'parent', but noparentquery parameter is present. The resolver currently falls back to the routeid, which is also absent on/communities/create, and requests the REST endpoint withundefined.Return an empty breadcrumb result when the optional parent parameter is absent. Existing community routes and sub-community creation routes continue to resolve their breadcrumbs normally.
Instructions for Reviewers
List of changes in this PR:
To verify:
/api/core/communities/undefined.Testing
git diff --check.The full repository npm test suite was not run locally because the dependency tree is not installed in this environment; CI should run the repository's standard checks.