Skip to content

METSReplicateConsumer: prevent unarchived items triggering replicate curation actions #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nwoodward merged 1 commit into from
Jun 24, 2026
Merged

METSReplicateConsumer: prevent unarchived items triggering replicate curation actions #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/main/java/org/dspace/ctask/replicate/METSReplicateConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,13 +199,21 @@ public void consume(Context ctx, Event event) throws Exception {

// make sure we are supposed to process this Collection
if (acceptId(id, event, ctx)) {
// --- NEW CHECK: Fetch and verify the item using event.getDetail() ---
String addedItemIdentifier = event.getDetail();
Item addedItem = itemService.findByIdOrLegacyId(ctx, addedItemIdentifier);

if (addedItem == null || !addedItem.isArchived()) {
// Skip replication if the item isn't archived yet
break;
}
// add Collection to the master lists of modified objects
// for which we need to perform tasks
mapId(taskQMap, modQTasks, id);
mapId(taskPMap, modPTasks, id);

//now, get Handle of Item that was mapped/added
id = event.getDetail();
id = addedItemIdentifier;

// add Item to the master lists of modified objects
// for which we need to perform tasks
Expand Down Expand Up @@ -252,16 +260,23 @@ public void consume(Context ctx, Event event) throws Exception {
break;
case MODIFY: // MODIFY = modify an object
case MODIFY_METADATA: // MODIFY_METADATA = just modify an object's metadata
DSpaceObject subjectObj = event.getSubject(ctx);
// If subject of event is null, this means the object was likely deleted
if (event.getSubject(ctx) == null) {
if (subjectObj == null) {
log.warn("{} event, could not get object for {} id={}, perhaps it has been deleted.",
event.getEventTypeAsString(), event.getSubjectTypeAsString(),
String.valueOf(event.getSubjectID()));
break;
}

// --- NEW CHECK: Skip unarchived items ---
if (subjType == Constants.ITEM && !((Item) subjectObj).isArchived()) {
break;
}
// ----------------------------------------

// For MODIFY events, the Handle of modified object needs to be obtained from the Subject
id = event.getSubject(ctx).getHandle();
id = subjectObj.getHandle();

// make sure handle resolves - these could be events
// for a newly created item that hasn't been assigned a handle
Expand Down
Loading