Repository navigation
breakpad: fix linking on Linux - #1825
Merged
Merged
Conversation
Member
Author
|
It built on Bullseye on my end. |
Member
|
LGTM |
illwieckz
force-pushed
the
illwieckz/linux-breakpad
branch
from
September 28, 2025 16:33
1685807 to
f6bc547
Compare
Member
Author
|
I modified it a bit to only set the definition for that I also now know how to make it work by listing the |
Member
Author
|
I merge this for the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1817:
It broke because the link didn't find the
breakpad_getcontextsymbol.I tried adding
src/common/linux/breakpad_getcontext.Sto the source list, but it didn't worked.Fortunately this source is only meant to be used when
getcontextisn't provided by the system, settingHAVE_GETCONTEXTtells the source the function is there.I haven't tested on Bullseye yet (Docker build distro). Actually I'm surprised that me testing the docker build didn't faced that error before. If it works on Bullseye, then we will assume it works everywhere.