Repository navigation
Mostly fix black loading screen on Mac - #1827
Merged
Merged
Conversation
Missed spot from SDL 3 migration. Both the fullscreen argument (changed from flags to bool) and the return value (changed to bool) were wrong. The flags mistake was harmless as it converted to the correct bool value, but the error checking was unreachable.
Member
|
Weird: |
slipher
force-pushed
the
mac-loading
branch
from
September 28, 2025 18:18
4f0074d to
79951d1
Compare
Member
Author
|
Oops, forgot the |
Member
|
Thanks for taking care of this! I'm merging this for the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1812