Repository navigation
Conversation
Come on, why do I have to put the .exe? There was supposed to be a commit doing this in DaemonEngine#2010 but then I accidentally removed it.
The version of the Saigo SDK download merged as part of DaemonEngine#2018 had some regressions compared to the original: - The path cache variable was not presented as a configurable option to the user on first configure. - If download failed, it could not be retried. - Disabling USE_EXTERNAL_DEPS did not stop external_deps from being automatically used. I do think it was a good idea to set SAIGOSDK_PREFIX in the cache upon downloading it. So I rewrote things a bit from the original to do this. It's important to set the cache only after the download succeeds to avoid the 2nd regression.
Make possible to cross-compile a Windows engine from Linux while running a native Linux SDK to build the NaCl game.
I originally wanted to use the name SAIGISDK_ROOT, but looking at the CMake cache for an Unvanquished build, DIR is by far the most common suffix for directories that pertain to a single dependency. (Sometimes ROOT_DIR is additionally used but we don't have any of those.) PREFIX is used more to refer to a Unix-style set up where multiple softwares may be mingled in the same directories. It's true that the Saigo SDK was built that way, installing several programs together, but that's not relevant for a CMake toolchain consumer. Anyway I think PREFIX is also not good because it's not too comprehensible to people without much Unixy background. I went many years in coding before understanding what "prefix" refers to.
slipher
force-pushed
the
saigosdk-merge
branch
from
November 4, 2026 18:31
7f844ff to
8a329f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fix-ups to get my work from #2010 to its true form.