Skip to content

misc fixes - #36

Open
delthas wants to merge 4 commits into
DanielOaks:masterfrom
delthas:fixes
Open

misc fixes#36
delthas wants to merge 4 commits into
DanielOaks:masterfrom
delthas:fixes

Conversation

@delthas

@delthas delthas commented Jul 8, 2020

Copy link
Copy Markdown

some fixes i had to add to make irctest work for my ircd.

running the tests on non-oragono servers is broken right now, even with these fixes, because some test cases with oragono tests still call setUp, tearDown that end up calling oragono-specific functions on the controllers, like baseConfig and addMysqlToConfig.

as a hotfix i added to my controller:

    def baseConfig(self):
        return {}

    def addMysqlToConfig(self, config=None):
        pass

also changed the run function to:

 def run(self, hostname, port, password=None, ssl=False,
            restricted_metadata_keys=None,
            valid_metadata_keys=None, invalid_metadata_keys=None, config=None):

because the tests need the config parameter even though it's oragono specific stuff.

so yeah the project is kinda broken for non-oragono servers anyways but here's some fixes for issues i had.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant