misc fixes - #36
Open
delthas wants to merge 4 commits into
Open
Conversation
the python bug got fixed, so we need to allow both behaviours
we need to skip that test if the caps are not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some fixes i had to add to make irctest work for my ircd.
running the tests on non-oragono servers is broken right now, even with these fixes, because some test cases with oragono tests still call setUp, tearDown that end up calling oragono-specific functions on the controllers, like baseConfig and addMysqlToConfig.
as a hotfix i added to my controller:
also changed the run function to:
because the tests need the config parameter even though it's oragono specific stuff.
so yeah the project is kinda broken for non-oragono servers anyways but here's some fixes for issues i had.