Skip to content

Add DatadogBYOCCluster API and CRD - #3494

Closed
shuheiktgw wants to merge 1 commit into
DataDog:mainfrom
shuheiktgw:add-byoc-api-crd
Closed

shuheiktgw wants to merge 1 commit into
DataDog:mainfrom
shuheiktgw:add-byoc-api-crd

Conversation

@shuheiktgw

@shuheiktgw shuheiktgw commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds the namespaced datadoghq.com/v1alpha1 DatadogBYOCCluster API. Most of the code is auto-generated, and the actual changes are in api/datadoghq/v1alpha1/datadogbyoccluster_types.go.

Additional Notes

  • I haven’t configured the CR printer columns yet. I’ll add them later.
  • This is PR 1 of the feature split from Add DatadogBYOCCluster CRD #3407. It establishes the API for the subsequent image resolution, resource generation, and controller PRs.

Checklist

  • PR has at least one valid label: enhancement (requires a maintainer to add it)
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed

@datadog-datadog-us1-prod

This comment has been minimized.

Comment thread hack/patch-crds.sh
# Remove defaultOverride section in DatadogAgent status due to the error: "datadoghq.com_datadogagents.yaml bigger than total allowed limit"
$YQ -i 'del(.spec.versions[].schema.openAPIV3Schema.properties.status.properties.defaultOverride)' "$ROOT/$v1/datadoghq.com_datadogagents.yaml"

# Remove OpenAPI schema descriptions from the BYOC CRD to keep its size under control.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in my comment here, the generated CRD is too large to be stored in etcd because it exceeds the maximum object size. To bring it under the size limit, the generator removes the field descriptions from the CRD schema.

@shuheiktgw
shuheiktgw marked this pull request as ready for review September 22, 2026 13:24
@shuheiktgw
shuheiktgw requested a review from a team September 22, 2026 13:24
@shuheiktgw
shuheiktgw requested a review from a team as a code owner September 22, 2026 13:24
@tbavelier tbavelier added this to the v1.32.0 milestone Sep 22, 2026
@tbavelier tbavelier added the enhancement New feature or request label Sep 22, 2026
@tbavelier

Copy link
Copy Markdown
Member

Closing it so it can be re-opened directly from a local branch

@tbavelier tbavelier closed this Sep 22, 2026
@shuheiktgw
shuheiktgw deleted the add-byoc-api-crd branch September 22, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants