fix(plugin): render Normal/OK state-bar lane green - #6
Open
David6811 wants to merge 1 commit into
Open
Conversation
Map --chart-state-normal to theme.colors.success.transparent instead of background.secondary. The Normal/OK lane was painted with Grafana's secondary background, so it blended into the page and the green OK segments were invisible — unlike the demo, which uses a muted green. success.transparent is theme-aware (dark/light) and matches the demo's intent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The plugin's Normal/OK state-bar lane was invisible — the green OK segments that the demo shows did not render inside Grafana.
Cause
--chart-state-normalwas mapped totheme.colors.background.secondary(Grafana's dark secondary background), so the Normal lane blended into the page. Pending/Firing usedwarning.main/error.mainand rendered fine, which is why only the green lane was missing.Fix
Map
--chart-state-normaltotheme.colors.success.transparent— a theme-aware (dark/light) green that matches the demo's muted-green intent.One line,
packages/plugin/src/pages/styles.ts.