Update tests for writegear option builder

Refactors recording option tests to target `build_writegear_options` directly instead of `RecordingSettings.writegear_options`, and aligns expectations with the newer option types/shape (numeric fps/crf values and explicit fast-encoding overrides). Also updates recording manager assertions to validate recorder codec/crf fields and narrowed writer overrides for x264 fast encoding.

Author: C-Achard

tests/gui/test_rec_manager.py

@@ -411,15 +411,20 @@ def test_start_all_passes_writegear_options(
     recording_settings.fast_encoding = True
 
     mgr = RecordingManager()
-    mgr.start_all(recording_settings, _active_cams_two, current_frames, session_name="Sess")
+    mgr.start_all(
+        recording_settings,
+        _active_cams_two,
+        current_frames,
+        session_name="Sess",
+    )
 
     for cam in _active_cams_two:
         cam_id = get_camera_id(cam)
         rec = mgr.recorders[cam_id]
 
-        opts_ovrr = rec.writer_options_overrides
-        assert opts_ovrr is not None
-        assert opts_ovrr["-vcodec"] == "libx264"
-        assert opts_ovrr["-crf"] == "23"
-        assert opts_ovrr["-preset"] == "ultrafast"
-        assert opts_ovrr["-tune"] == "zerolatency"
+        assert rec.codec == "libx264"
+        assert rec.crf == 23
+        assert rec.writer_options_overrides == {
+            "-preset": "ultrafast",
+            "-tune": "zerolatency",
+        }

tests/test_config.py

@@ -1,12 +1,14 @@
 import pytest
 
 from dlclivegui.config import (
+    DEFAULT_RECORDING_FPS,
     ApplicationSettings,
     CameraSettings,
     CameraTriggerSettings,
     MultiCameraSettings,
     RecordingSettings,
 )
+from dlclivegui.services.video_recorder import build_writegear_options
 
 
 @pytest.mark.unit
@@ -76,43 +78,82 @@ def test_trigger_source_defaults_to_auto():
     assert trigger.source == "auto"
 
 
-def test_recording_settings_writegear_options_default():
-    settings = RecordingSettings(codec="libx264", crf=23, fast_encoding=False)
+def test_build_writegear_options_default():
+    settings = RecordingSettings(
+        codec="libx264",
+        crf=23,
+        fast_encoding=False,
+    )
 
-    opts = settings.writegear_options(100.0)
+    opts = build_writegear_options(
+        frame_rate=100.0,
+        codec=settings.codec,
+        crf=settings.crf,
+        overrides=settings.writegear_overrides(),
+    )
 
-    assert opts["-input_framerate"] == "100.000000"
-    assert opts["-vcodec"] == "libx264"
-    assert opts["-crf"] == "23"
-    assert "-preset" not in opts
-    assert "-tune" not in opts
+    assert opts == {
+        "-input_framerate": 100.0,
+        "-vcodec": "libx264",
+        "-crf": 23,
+    }
 
 
-def test_recording_settings_writegear_options_fast_encoding_x264():
-    settings = RecordingSettings(codec="libx264", crf=23, fast_encoding=True)
+def test_build_writegear_options_fast_encoding_x264():
+    settings = RecordingSettings(
+        codec="libx264",
+        crf=23,
+        fast_encoding=True,
+    )
 
-    opts = settings.writegear_options(100.0)
+    opts = build_writegear_options(
+        frame_rate=100.0,
+        codec=settings.codec,
+        crf=settings.crf,
+        overrides=settings.writegear_overrides(),
+    )
 
-    assert opts["-input_framerate"] == "100.000000"
-    assert opts["-vcodec"] == "libx264"
-    assert opts["-crf"] == "23"
-    assert opts["-preset"] == "ultrafast"
-    assert opts["-tune"] == "zerolatency"
+    assert opts == {
+        "-input_framerate": 100.0,
+        "-vcodec": "libx264",
+        "-crf": 23,
+        "-preset": "ultrafast",
+        "-tune": "zerolatency",
+    }
 
 
-def test_recording_settings_writegear_options_fast_encoding_nvenc_no_x264_options():
-    settings = RecordingSettings(codec="h264_nvenc", crf=23, fast_encoding=True)
+def test_build_writegear_options_fast_encoding_nvenc():
+    settings = RecordingSettings(
+        codec="h264_nvenc",
+        crf=23,
+        fast_encoding=True,
+    )
 
-    opts = settings.writegear_options(100.0)
+    opts = build_writegear_options(
+        frame_rate=100.0,
+        codec=settings.codec,
+        crf=settings.crf,
+        overrides=settings.writegear_overrides(),
+    )
 
+    assert opts["-input_framerate"] == 100.0
     assert opts["-vcodec"] == "h264_nvenc"
+    assert opts["-crf"] == 23
     assert "-preset" not in opts
     assert "-tune" not in opts
 
 
-def test_recording_settings_writegear_options_invalid_fps_falls_back_to_30():
-    settings = RecordingSettings(codec="libx264", crf=23)
+def test_build_writegear_options_invalid_fps_uses_default():
+    settings = RecordingSettings(
+        codec="libx264",
+        crf=23,
+    )
 
-    opts = settings.writegear_options(None)
+    opts = build_writegear_options(
+        frame_rate=None,
+        codec=settings.codec,
+        crf=settings.crf,
+        overrides=settings.writegear_overrides(),
+    )
 
-    assert opts["-input_framerate"] == "30.000000"
+    assert opts["-input_framerate"] == DEFAULT_RECORDING_FPS