Refactor recording option tests

Reworked tests to match the split between base WriteGear option construction and config-level overrides. Added focused unit coverage for `build_writegear_options` (default values, FPS fallback, invalid FPS handling, and override merging), updated `RecordingSettings` tests to validate `writegear_overrides()` behavior by codec/fast-encoding mode, and relaxed GUI manager assertions to only check override-specific flags.

Author: C-Achard

tests/gui/main_window/test_ui.py

@@ -50,4 +50,4 @@ def test_label_for_cam_id_uses_runtime_display_id_fallback(self, window):
         assert w._label_for_cam_id("runtime:id") == "Runtime Camera"
 
     def test_label_for_cam_id_unknown_is_neutral(self, window):
-        assert window._label_for_cam_id("missing:id") == "Unknown camera"
+        assert "Unknown camera" in window._label_for_cam_id("missing:id")

tests/services/test_video_recorder.py

@@ -9,6 +9,7 @@
 import pytest
 
 import dlclivegui.services.video_recorder as vr_mod
+from dlclivegui.config import DEFAULT_RECORDING_FPS
 from dlclivegui.utils.timestamps import FrameTimestampMetadata
 
 # ----------------------------
@@ -528,3 +529,63 @@ def test_stop_writes_hardware_timestamp_metadata_sidecar_json(
             "raw_value": 1_000_000,
         }
         assert rec0["hardware_timestamp_default"] == 0.001
+
+
+def test_build_writegear_options_default():
+    opts = vr_mod.build_writegear_options(
+        frame_rate=100.0,
+        codec="libx264",
+        crf=23,
+    )
+
+    assert opts == {
+        "-input_framerate": 100.0,
+        "-vcodec": "libx264",
+        "-crf": 23,
+    }
+
+
+def test_build_writegear_options_invalid_fps_uses_default():
+    opts = vr_mod.build_writegear_options(
+        frame_rate=0.0,
+        codec="libx264",
+        crf=23,
+    )
+
+    assert opts["-input_framerate"] == DEFAULT_RECORDING_FPS
+
+
+@pytest.mark.parametrize(
+    "frame_rate",
+    [None, 0, -1, "invalid"],
+)
+def test_build_writegear_options_unusable_fps_uses_default(
+    frame_rate,
+):
+    opts = vr_mod.build_writegear_options(
+        frame_rate=frame_rate,
+        codec="libx264",
+        crf=23,
+    )
+
+    assert opts["-input_framerate"] == DEFAULT_RECORDING_FPS
+
+
+def test_build_writegear_options_merges_overrides():
+    opts = vr_mod.build_writegear_options(
+        frame_rate=100.0,
+        codec="libx264",
+        crf=23,
+        overrides={
+            "-preset": "ultrafast",
+            "-tune": "zerolatency",
+        },
+    )
+
+    assert opts == {
+        "-input_framerate": 100.0,
+        "-vcodec": "libx264",
+        "-crf": 23,
+        "-preset": "ultrafast",
+        "-tune": "zerolatency",
+    }

tests/test_config.py

@@ -78,6 +78,44 @@ def test_trigger_source_defaults_to_auto():
     assert trigger.source == "auto"
 
 
+@pytest.mark.unit
+def test_recording_settings_writegear_overrides_default():
+    settings = RecordingSettings(
+        codec="libx264",
+        crf=23,
+        fast_encoding=False,
+    )
+
+    assert settings.writegear_overrides() == {}
+
+
+@pytest.mark.unit
+@pytest.mark.parametrize("codec", ["libx264", "libx265"])
+def test_recording_settings_writegear_overrides_fast_encoding(codec):
+    settings = RecordingSettings(
+        codec=codec,
+        crf=23,
+        fast_encoding=True,
+    )
+
+    assert settings.writegear_overrides() == {
+        "-preset": "ultrafast",
+        "-tune": "zerolatency",
+    }
+
+
+@pytest.mark.unit
+def test_recording_settings_writegear_overrides_nvenc():
+    settings = RecordingSettings(
+        codec="h264_nvenc",
+        crf=23,
+        fast_encoding=True,
+    )
+
+    assert settings.writegear_overrides() == {}
+
+
+@pytest.mark.unit
 def test_build_writegear_options_default():
     settings = RecordingSettings(
         codec="libx264",
@@ -97,10 +135,9 @@ def test_build_writegear_options_default():
         "-vcodec": "libx264",
         "-crf": 23,
     }
-    assert "-preset" not in opts
-    assert "-tune" not in opts
 
 
+@pytest.mark.unit
 def test_build_writegear_options_fast_encoding_x264():
     settings = RecordingSettings(
         codec="libx264",
@@ -124,6 +161,7 @@ def test_build_writegear_options_fast_encoding_x264():
     }
 
 
+@pytest.mark.unit
 def test_build_writegear_options_fast_encoding_nvenc():
     settings = RecordingSettings(
         codec="h264_nvenc",
@@ -138,13 +176,14 @@ def test_build_writegear_options_fast_encoding_nvenc():
         overrides=settings.writegear_overrides(),
     )
 
-    assert opts["-input_framerate"] == 100.0
-    assert opts["-vcodec"] == "h264_nvenc"
-    assert opts["-crf"] == 23
-    assert "-preset" not in opts
-    assert "-tune" not in opts
+    assert opts == {
+        "-input_framerate": 100.0,
+        "-vcodec": "h264_nvenc",
+        "-crf": 23,
+    }
 
 
+@pytest.mark.unit
 def test_build_writegear_options_invalid_fps_uses_default():
     settings = RecordingSettings(
         codec="libx264",
@@ -158,4 +197,4 @@ def test_build_writegear_options_invalid_fps_uses_default():
         overrides=settings.writegear_overrides(),
     )
 
-    assert opts["-input_framerate"] == DEFAULT_RECORDING_FPS
+    assert opts["-input_framerate"] == DEFAULT_RECORDING_FPS