Skip to content

Commit cb26273

Browse files
committed
Route recording frames through recording sink
Switch `RecordingManager` import to the new `services` package path and update recording flow to use an explicit recording sink callback. Recording now sets `multi_camera_controller.set_recording_sink(self._rec_manager.write_frame)` when starting and clears it on stop, replacing the previous direct `recording_frame_ready` signal hookup.
1 parent a896dad commit cb26273

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

‎dlclivegui/gui/main_window.py‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@
7171
)
7272
from ..services.dlc_processor import DLCLiveProcessor, PoseResult
7373
from ..services.multi_camera_controller import MultiCameraController, MultiFrameData, get_camera_id, get_display_id
74+
from ..services.recording_manager import RecordingManager
7475
from ..utils.display import BBoxColors, compute_tile_info, create_tiled_frame, draw_bbox, draw_pose
7576
from ..utils.settings_store import DLCLiveGUISettingsStore, ModelPathStore
7677
from ..utils.stats import WorkerTimingStats, format_dlc_stats
@@ -80,7 +81,6 @@
8081
from .misc import layouts as lyts
8182
from .misc.drag_spinbox import ScrubSpinBox
8283
from .misc.eliding_label import ElidingPathLabel
83-
from .recording_manager import RecordingManager
8484
from .theme import LOGO, LOGO_ALPHA, AppStyle, apply_theme
8585

8686
logger = logging.getLogger("DLCLiveGUI")
@@ -802,7 +802,7 @@ def _connect_signals(self) -> None:
802802
# Multi-camera controller signals (used for both single and multi-camera modes)
803803
self.multi_camera_controller.frame_ready.connect(self._on_multi_frame_processing_ready)
804804
self.multi_camera_controller.display_ready.connect(self._on_multi_frame_display_ready)
805-
self.multi_camera_controller.recording_frame_ready.connect(self._on_recording_frame_ready)
805+
# self.multi_camera_controller.recording_frame_ready.connect(self._on_recording_frame_ready)
806806
self.multi_camera_controller.all_started.connect(self._on_multi_camera_started)
807807
self.multi_camera_controller.all_stopped.connect(self._on_multi_camera_stopped)
808808
self.multi_camera_controller.camera_error.connect(self._on_multi_camera_error)
@@ -1606,6 +1606,7 @@ def _start_multi_camera_recording(self) -> None:
16061606
if run_dir is None:
16071607
self._show_error("Failed to start recording.")
16081608
return
1609+
self.multi_camera_controller.set_recording_sink(self._rec_manager.write_frame)
16091610
self.multi_camera_controller.set_recording_frame_do_emit(True)
16101611

16111612
self._settings_store.set_session_name(session_name)
@@ -1630,6 +1631,7 @@ def _stop_multi_camera_recording(self) -> None:
16301631
# Stop frame emission immediately so no new frames enter recording pipeline.
16311632
try:
16321633
self.multi_camera_controller.set_recording_frame_do_emit(False)
1634+
self.multi_camera_controller.set_recording_sink(None)
16331635
except Exception:
16341636
logger.exception("Failed to disable recording frame emission")
16351637

0 commit comments

Comments
 (0)