Preserve skeleton style settings from UI

Keep a dedicated `SkeletonStyle` state on the main window and sync it when loading visualization settings, so non-UI-exposed fields (`gradient_steps`, `scale_with_zoom`) are preserved instead of being pulled from stale config data. The UI-to-settings path now updates and reuses this state consistently. Also renames `test_frame` factory parameters in display tests (`height/width/channels` -> `h/w/c`) to match current call patterns.

Author: C-Achard

dlclivegui/gui/main_window.py

@@ -189,6 +189,7 @@ def __init__(self, config: ApplicationSettings | None = None):
         self._p_cutoff = 0.6
         self._colormap = "hot"
         self._bbox_color = (0, 0, 255)  # BGR: red
+        self._skeleton_style = SkeletonStyle()
         self._overlay_renderer = OverlayRenderer()
 
         # Multi-camera state
@@ -990,6 +991,7 @@ def _apply_config(self, config: ApplicationSettings, *, restore_local_prefs: boo
         self._p_cutoff = viz.p_cutoff
         self._colormap = viz.colormap
         self._bbox_color = viz.get_bbox_color_bgr()
+        self._skeleton_style = viz.skeleton_style.model_copy(deep=True)
 
         self.show_predictions_checkbox.blockSignals(True)
         try:
@@ -1146,13 +1148,16 @@ def _bbox_settings_from_ui(self) -> BoundingBoxSettings:
     def _visualization_settings_from_ui(
         self,
     ) -> VisualizationSettings:
+        skeleton_style = self._skeleton_style_from_ui()
+        self._skeleton_style = skeleton_style
+
         return VisualizationSettings(
             p_cutoff=self._p_cutoff,
             colormap=self._colormap,
             bbox_color=self._bbox_color,
             show_pose=self.show_predictions_checkbox.isChecked(),
             show_skeleton=self.show_skeleton_checkbox.isChecked(),
-            skeleton_style=self._skeleton_style_from_ui(),
+            skeleton_style=skeleton_style,
         )
 
     def _overlay_settings_from_ui(
@@ -1191,14 +1196,12 @@ def _skeleton_style_from_ui(
 
         color_bgr = tuple(color) if color is not None else (0, 255, 255)
 
-        current_style = self._config.visualization.skeleton_style
-
         return SkeletonStyle(
             color_mode=SkeletonColorMode(mode),
             color_bgr=color_bgr,
             thickness=self.skeleton_thickness_spin.value(),
-            gradient_steps=current_style.gradient_steps,
-            scale_with_zoom=current_style.scale_with_zoom,
+            gradient_steps=self._skeleton_style.gradient_steps,
+            scale_with_zoom=self._skeleton_style.scale_with_zoom,
         )
 
     def _suggest_config_dialog_path(self) -> str:

tests/display/conftest.py

@@ -12,15 +12,15 @@ def test_frame() -> Callable[..., np.ndarray]:
     """Return a factory for creating predictable test frames."""
 
     def make_frame(
-        height: int,
-        width: int,
-        channels: int = 3,
+        h: int,
+        w: int,
+        c: int = 3,
         value: int | float = 0,
         dtype: np.dtype = np.uint8,
     ) -> np.ndarray:
         if not isinstance(dtype, np.dtype):
             dtype = np.dtype(dtype)
-        shape = (height, width) if channels == 1 else (height, width, channels)
+        shape = (h, w) if c == 1 else (h, w, c)
         return np.full(shape, value, dtype=dtype)
 
     return make_frame