Revise POET weights dialog test coverage

Reworks `test_weights_dialog.py` to match the updated POET download dialog behavior. The tests now validate default destination/status UI, progress updates, successful download completion and cleanup signaling, failure cleanup control restoration, and reject behavior during active vs idle download states.

Author: C-Achard

tests/gui/ui_blocks/test_weights_dialog.py

@@ -1,98 +1,113 @@
+from __future__ import annotations
+
 from PySide6.QtCore import Qt
-from PySide6.QtWidgets import QFileDialog
+from PySide6.QtWidgets import QDialog
 
 from dlclivegui.gui.misc.weights_dialog import PoetWeightsDialog
 
 
-def test_dialog_without_initial_path_disables_use_button(
+def test_dialog_shows_download_destination(
+    qtbot,
+) -> None:
+    dialog = PoetWeightsDialog()
+    qtbot.addWidget(dialog)
+
+    assert dialog.path_label.full_text == str(dialog._destination)
+    assert dialog.path_label.text()
+    assert dialog.path_label.textInteractionFlags() & Qt.TextInteractionFlag.TextSelectableByMouse
+    assert dialog.status_label.text() == "Ready to download."
+    assert dialog.progress_bar.value() == 0
+    assert dialog.download_button.isEnabled()
+    assert dialog.close_button.isEnabled()
+
+
+def test_update_progress_updates_progress_and_status(
     qtbot,
 ) -> None:
     dialog = PoetWeightsDialog()
     qtbot.addWidget(dialog)
 
-    assert dialog.path_label.text() == "No weights selected"
-    assert not dialog.use_button.isEnabled()
-    assert not dialog.progress_bar.isVisible()
+    dialog._update_progress(42)
 
+    assert dialog.progress_bar.value() == 42
+    assert dialog.status_label.text() == "Downloading POET weights... 42%"
 
-def test_dialog_accepts_valid_initial_path(
+
+def test_download_finished_records_completed_path(
     qtbot,
     tmp_path,
 ) -> None:
     path = tmp_path / "weights.pth"
     path.touch()
 
-    dialog = PoetWeightsDialog(initial_path=str(path))
+    dialog = PoetWeightsDialog()
     qtbot.addWidget(dialog)
 
-    assert dialog.path_label.text() == str(path)
-    assert dialog.use_button.isEnabled()
+    dialog._download_finished(str(path))
+
+    assert dialog._completed_path == str(path)
+    assert dialog.progress_bar.value() == 100
+    assert dialog.status_label.text() == ("Download complete. Returning to the main window...")
 
 
-def test_use_selected_emits_path(
+def test_download_cleanup_emits_path_and_accepts(
     qtbot,
     tmp_path,
 ) -> None:
     path = tmp_path / "weights.pth"
     path.touch()
 
-    dialog = PoetWeightsDialog(initial_path=str(path))
+    dialog = PoetWeightsDialog()
     qtbot.addWidget(dialog)
+    dialog._completed_path = str(path)
 
     with qtbot.waitSignal(
-        dialog.weights_selected,
+        dialog.weights_downloaded,
         timeout=1000,
     ) as blocker:
-        qtbot.mouseClick(
-            dialog.use_button,
-            Qt.MouseButton.LeftButton,
-        )
+        dialog._download_cleanup()
 
     assert blocker.args == [str(path)]
+    assert dialog.result() == QDialog.DialogCode.Accepted
+    assert dialog._download_thread is None
+    assert dialog._download_worker is None
 
 
-def test_browse_sets_selected_path(
+def test_download_cleanup_after_failure_restores_controls(
     qtbot,
-    monkeypatch,
-    tmp_path,
 ) -> None:
-    path = tmp_path / "weights.pth"
-    path.touch()
+    dialog = PoetWeightsDialog()
+    qtbot.addWidget(dialog)
 
-    monkeypatch.setattr(
-        QFileDialog,
-        "getOpenFileName",
-        lambda *args, **kwargs: (
-            str(path),
-            "POET weights (*.pt *.pth)",
-        ),
-    )
+    dialog.download_button.setEnabled(False)
+    dialog.close_button.setEnabled(False)
+    dialog._completed_path = None
+
+    dialog._download_cleanup()
+
+    assert dialog.download_button.isEnabled()
+    assert dialog.close_button.isEnabled()
 
+
+def test_reject_is_ignored_while_download_is_active(
+    qtbot,
+) -> None:
     dialog = PoetWeightsDialog()
     qtbot.addWidget(dialog)
 
-    dialog._browse()
+    dialog._download_thread = object()
+
+    dialog.reject()
 
-    assert dialog.path_label.text() == str(path)
-    assert dialog.use_button.isEnabled()
+    assert dialog.result() == 0
 
 
-def test_download_cleanup_restores_controls(
+def test_reject_closes_when_idle(
     qtbot,
-    tmp_path,
 ) -> None:
-    path = tmp_path / "weights.pth"
-    path.touch()
-
     dialog = PoetWeightsDialog()
     qtbot.addWidget(dialog)
 
-    dialog._set_selected_path(str(path))
-    dialog.browse_button.setEnabled(False)
-    dialog.download_button.setEnabled(False)
-
-    dialog._download_cleanup()
+    dialog.reject()
 
-    assert dialog.browse_button.isEnabled()
-    assert dialog.download_button.isEnabled()
-    assert dialog.use_button.isEnabled()
+    assert dialog.result() == QDialog.DialogCode.Rejected