Skip to content

Commit e1e8f93

Browse files
committed
Remove unused recording frame callback
Deletes `_on_recording_frame_ready` from `main_window.py`, removing a lean per-camera recording path that bypassed processing, DLC routing, display updates, and FPS tracking. This cleanup reduces dead code and keeps frame handling centered on the multi-frame processing flow.
1 parent fecfb0c commit e1e8f93

1 file changed

Lines changed: 0 additions & 21 deletions

File tree

‎dlclivegui/gui/main_window.py‎

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -856,7 +856,6 @@ def _connect_signals(self) -> None:
856856
# Multi-camera controller signals (used for both single and multi-camera modes)
857857
self.multi_camera_controller.frame_ready.connect(self._on_multi_frame_processing_ready)
858858
self.multi_camera_controller.display_ready.connect(self._on_multi_frame_display_ready)
859-
# self.multi_camera_controller.recording_frame_ready.connect(self._on_recording_frame_ready)
860859
self.multi_camera_controller.all_started.connect(self._on_multi_camera_started)
861860
self.multi_camera_controller.all_stopped.connect(self._on_multi_camera_stopped)
862861
self.multi_camera_controller.camera_error.connect(self._on_multi_camera_error)
@@ -1695,26 +1694,6 @@ def _render_overlays_for_recording(self, cam_id, frame):
16951694
)
16961695
return output
16971696

1698-
def _on_recording_frame_ready(
1699-
self, camera_id: str, frame: np.ndarray, timestamp: float, timestamp_metadata: object | None = None
1700-
) -> None:
1701-
"""Handle full-rate per-camera frames for recording only.
1702-
1703-
Intentionally lean:
1704-
- no MultiFrameData processing
1705-
- no DLC routing
1706-
- no display state updates
1707-
- no FPS tracker
1708-
- optional overlays only if user requested recording overlays
1709-
"""
1710-
if not self._rec_manager.is_active:
1711-
return
1712-
1713-
# if self.record_with_overlays_checkbox.isChecked():
1714-
# frame = self._render_overlays_for_recording(camera_id, frame)
1715-
1716-
self._rec_manager.write_frame(camera_id, frame, timestamp, timestamp_metadata=timestamp_metadata)
1717-
17181697
def _on_multi_frame_processing_ready(self, frame_data: MultiFrameData) -> None:
17191698
"""Handle frames from multiple cameras.
17201699

0 commit comments

Comments
 (0)