Skip to content

Commit fecfb0c

Browse files
committed
Clarify stop-inference data loss warning
Improves the recording-stop confirmation text to clearly state that standard recording-stopped save hooks are bypassed, saving depends on processor stop handling, and unsaved processor data may be lost or unpaired. Also adds an inline code comment documenting that reset does not trigger normal recording stop/save hooks.
1 parent fbbefe7 commit fecfb0c

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

‎dlclivegui/gui/main_window.py‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2503,8 +2503,9 @@ def _stop_inference(self, show_message: bool = True) -> None:
25032503
self,
25042504
"Stop inference while recording?",
25052505
"This will stop the currently running DLC-live custom processor, if any.\n"
2506-
"File saving will not be handled via the standard 'recording stopped' event hooks."
2507-
"The processor might still save data now, but it will not be paired with the recording.\n\n"
2506+
"File saving will not be handled via the standard 'recording stopped' event hooks"
2507+
", so data will only be saved if the processor handles saving on stop.\n\n"
2508+
"Unsaved processor data may be lost or not be paired with the recording.\n\n"
25082509
"Stop inference anyway?",
25092510
)
25102511
if answer != QMessageBox.Yes:
@@ -2513,6 +2514,7 @@ def _stop_inference(self, show_message: bool = True) -> None:
25132514
was_active = self._dlc_active
25142515
self._dlc_active = False
25152516
self._dlc_initialized = False
2517+
# Does NOT invoke the normal rec-stop/save hooks. Persistence is processor-dependent.
25162518
self._dlc.reset(reset_processor_plugin=True)
25172519
self._last_pose = None
25182520
self._last_processor_vid_recording = False

0 commit comments

Comments
 (0)