all notebooks are updated and should be working - #46
Open
altaykerem wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Sorry if this is a lot of change all at once! I liked the book and as I read it I made some changes to match/fix/explain the code. As I did these, at the end of the book, I though it would be nice to share.
Overall
Appendix
Chapter 2
Listing 2.9
Section 2.4 Working with PyTorch
Chapter 3
makeMovelike in a gym environmentListing 3.2
Listing 3.3
state,state1got confusedreward == -1PyTorch Automatic Differentiation Review
@ xfor no reasonListing 3.5
Listing 3.7
Chapter 4
Listing 4.4
Visual Gameplay
Chapter 5
I worked around the issue of multiprocessing not working with the notebook in some systems by:
Calling scripts from the notebook lost variables so models were pickled
Listing 5.1
Listing 5.6
Listing 5.9
Chapter 6
Listing 6.4
Chapter 7
Listing 7.14
Chapter 8
Listing 8.11
use_extrinsicanduse_explicit.Listing 8.13
last_x_posis not actually 0 at the start of the gameChapter 9
Listing 9.13
Listing 9.16
linside the functionget_onehot.Listing 9.20
Listing 9.21