Skip to content

Align guided Inspector and export tutorials - #1

Merged
Denys merged 1 commit into
mainfrom
codex/sync-tutorials-20260901
Sep 1, 2026
Merged

Denys merged 1 commit into
mainfrom
codex/sync-tutorials-20260901

Conversation

@Denys

@Denys Denys commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Aligns the public tutorial path with the original BASE while preserving the clean repository scope. Adds an illustrated Inspector/Hardware/Export/Advanced tutorial, links every tutorial from the README, and fixes export preview construction so the saved hardware target, mapping, and Poly Voice Blankets reach code generation.

Verification:

  • 883 tests passed
  • ESLint: 0 errors, 146 existing warnings
  • Production build passed
  • 9 Markdown files checked for local links
  • Four new screenshots visually inspected; Advanced image contains no API key

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T13:44:32.477458Z e021160 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Denys
Denys merged commit c20f5fc into main Sep 1, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e021160ff2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread dvpe_CLD/src/App.tsx
blocks,
connections,
polyVoiceBlankets,
hardwareConfig,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Validate Field mappings only for a Field export

When a project has Field mappings and the user later switches the target to Seed or Pod, setHardwareConfig deliberately retains fieldControlMappings; forwarding the complete configuration here makes CodeGenerator.generate() run buildFieldMappingConflictErrors() on those inactive mappings unconditionally. Consequently, a retained mapping whose target now has a graph connection blocks an otherwise valid Seed/Pod export, even though getFieldControlMappings() correctly ignores mappings for non-Field targets. Gate conflict validation on the active platform or pass only active mappings.

Useful? React with 👍 / 👎.

Comment on lines +94 to +95
7. When processing succeeds, compare **Raw (DVPE)** and **AI Corrected** in the
preview before downloading.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Do not promise usable corrected files before wiring downloads

After a successful Advanced Export, the UI only displays aiCorrectedCode.mainCpp; handleDownload and downloadViaBrowser always package generatedCode.mainCpp and generatedCode.makefile, so the corrected C++ and corrected Makefile cannot be downloaded or fully diffed as this new workflow directs. Users following the tutorial will unknowingly compile the raw export instead of the reviewed correction; either make Download Files use the selected result (including its Makefile) or document that the corrected result is preview-only.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant