Merge pull request #319 from DeterminateSystems/otel-execution-failure-on-the-span

Otel execution failure on the span

Author: grahamc

dist/index.js

@@ -171782,7 +171782,6 @@ function makeNixCommandArgs(nixOptions, flakeInputs, commitMessage) {
 // src/index.ts
 
 
-var EVENT_EXECUTION_FAILURE = "detsys.execution_failure";
 var ATTR_EXIT_CODE = "detsys.exit_code";
 var UpdateFlakeLockAction = class extends DetSysAction {
   constructor() {
@@ -171828,10 +171827,9 @@ var UpdateFlakeLockAction = class extends DetSysAction {
       );
       span.setAttribute(ATTR_EXIT_CODE, exitCode);
       if (exitCode !== 0) {
-        this.addEvent(EVENT_EXECUTION_FAILURE, {
-          [ATTR_EXIT_CODE]: exitCode
-        });
-        log_exports.setFailed(`non-zero exit code of ${exitCode} detected`);
+        const failure = new Error(`non-zero exit code of ${exitCode} detected`);
+        recordSpanError(span, failure);
+        log_exports.setFailed(failure);
       } else {
         log_exports.info(`flake.lock file was successfully updated`);
       }

dist/index.js.map

@@ -4,11 +4,10 @@ import {
   DetSysAction,
   inputs,
   log,
+  recordSpanError,
   withSpan,
 } from "@determinate-systems/detsys-ts";
 
-const EVENT_EXECUTION_FAILURE = "detsys.execution_failure";
-
 const ATTR_EXIT_CODE = "detsys.exit_code";
 
 class UpdateFlakeLockAction extends DetSysAction {
@@ -73,10 +72,11 @@ class UpdateFlakeLockAction extends DetSysAction {
       span.setAttribute(ATTR_EXIT_CODE, exitCode);
 
       if (exitCode !== 0) {
-        this.addEvent(EVENT_EXECUTION_FAILURE, {
-          [ATTR_EXIT_CODE]: exitCode,
-        });
-        log.setFailed(`non-zero exit code of ${exitCode} detected`);
+        // The program failed, thus the span failed. The exit code is already
+        // on the span, which is all that the event carried.
+        const failure = new Error(`non-zero exit code of ${exitCode} detected`);
+        recordSpanError(span, failure);
+        log.setFailed(failure);
       } else {
         log.info(`flake.lock file was successfully updated`);
       }