Skip to content

Replace eslint with oxlint and bump deps - #324

Merged
gustavderdrache merged 3 commits into
mainfrom
gustavderdrache/push-pwnwqzrvtysy
Oct 21, 2026
Merged

gustavderdrache merged 3 commits into
mainfrom
gustavderdrache/push-pwnwqzrvtysy

Conversation

@gustavderdrache

@gustavderdrache gustavderdrache commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Also includes a fix to the README after oxfmt mangled the template formatting. I brought it in line with the current template in action.yml.

Summary by CodeRabbit

  • Documentation

    • Updated setup examples, formatting, and pull request guidance for greater clarity.
    • Clarified GPG verification instructions and simplified the default pull request template.
  • Developer Experience

    • Migrated code quality and formatting workflows to updated tooling.
    • Added configuration to keep generated build output excluded from formatting and lint checks.
    • Improved TypeScript project file discovery.
  • Maintenance

    • Updated the test framework and refreshed development tooling configuration without changing application behavior.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: b2c23e4a-5d5c-4615-8795-985eda3a41a5
📥 Commits

Reviewing files that changed from the base of the PR and between 94ec866 and df85f89.

⛔ Files ignored due to path filters: 3
  • dist/index.js is excluded by !**/dist/**
  • dist/index.js.map is excluded by !**/dist/**, !**/*.map
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing: 12
  • .eslintrc.json
  • .prettierignore
  • README.md
  • oxfmt.config.mts
  • oxlint.config.mts
  • package.json
  • prettier.config.cjs
  • src/index.ts
  • src/nix.test.ts
  • src/nix.ts
  • tsconfig.json
  • tsup.config.ts
💤 Files with no reviewable changes: 2
  • .prettierignore
  • .eslintrc.json

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

The pull request replaces ESLint and Prettier commands and dependencies with Oxlint and Oxfmt. It also changes Nix action exit handling, updates project configuration, and revises README examples and pull request instructions.

Changes: Repository updates

Layer / File(s) Summary
Tooling configuration
.eslintrc.json, .prettierignore, oxfmt.config.mts, oxlint.config.mts, package.json, prettier.config.cjs, tsconfig.json, tsup.config.ts
The package scripts and development dependencies now use Oxfmt and Oxlint. New formatter and linter configurations exclude dist. Package metadata and TypeScript configuration also changed.
Nix action execution
src/index.ts, src/nix.ts, src/nix.test.ts
UpdateFlakeLockAction.update returns the withSpan promise directly. Exit code zero logs success; other exit codes mark the span as failed and fail the action. Nix command construction and its tests have formatting and declaration edits.
README examples and instructions
README.md
Examples use updated quoting and spacing. The default pull request instructions now say to close and reopen the pull request to trigger GitHub Actions workflows.

Priority: ⚪ Pending latest changes

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Other

Suggested reviewers: lucperkins

Merge Risk: ⚪ Minimal · up to df85f

No merge-blocking issue was identified; the changes are ready for normal build and test checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main changes: replacing ESLint with Oxlint and updating dependencies.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 7 files. (3 skipped: 3 …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 7 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@gustavderdrache
gustavderdrache force-pushed the gustavderdrache/push-pwnwqzrvtysy branch from df85f89 to 25da8e9 Compare October 21, 2026 16:48
@gustavderdrache
gustavderdrache merged commit f02139a into main Oct 21, 2026
4 checks passed
@gustavderdrache
gustavderdrache deleted the gustavderdrache/push-pwnwqzrvtysy branch October 21, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants