Skip to content

Commit 66d9c2b

Browse files
authored
Merge pull request #2304 from pcristin/codex/fix-cli-fixture-lifetime
test(cli): keep fixture host until released
2 parents 64cf275 + 262d7ca commit 66d9c2b

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

‎tests/test_cli.c‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1653,8 +1653,9 @@ static _Noreturn void cli_scope_host_child(const cli_scope_fixture_t *fixture, i
16531653
(void)write(ready_fd, &ready, 1);
16541654
close(ready_fd);
16551655
bool drained = false;
1656-
uint64_t deadline = cbm_now_ms() + 120000U;
1657-
while (ready_ok && cbm_now_ms() < deadline) {
1656+
/* The parent owns the release pipe. If it exits, poll observes POLLHUP;
1657+
* a fixed lifetime can stop a healthy host during a slow binary install. */
1658+
while (ready_ok) {
16581659
if (cbm_daemon_runtime_service_wait_exited(service, 50U)) {
16591660
drained = true;
16601661
break;

0 commit comments

Comments
 (0)