Skip to content

Commit 83d6a78

Browse files
committed
test(venue): re-home the isolated-release-download guard
Deleting the archive-extractor contract took an assertion with it that had nothing to do with the UI-pack architecture that contract tested: release.yml and dry-run.yml must stage downloaded archives into $RUNNER_TEMP, not into the tracked checkout, so the extractor never scans a directory that also holds repo files. The fix itself survived the revert; only its guard died. Moved to the venue-parity contract, which already reads both workflows and is registered in scripts/test.sh. Revert-checked: reverting release.yml to ARCHIVE_DIR="assets" makes this fail with the exact message, and restoring it passes. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
1 parent fe7f371 commit 83d6a78

1 file changed

Lines changed: 16 additions & 0 deletions

File tree

‎tests/test_venue_parity_contract.sh‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -343,6 +343,22 @@ for path in sorted(shell_surfaces):
343343
"under native Windows process lookup"
344344
)
345345
346+
# ── Release archives are extracted from an ISOLATED directory ──
347+
# The release/dry-run verify jobs used to download archives into the tracked
348+
# checkout, so the extractor scanned a directory that also held repo files.
349+
# Both now stage into $RUNNER_TEMP. This assertion lived in the archive-extractor
350+
# contract, which was deleted with the UI-pack architecture it tested; the fix
351+
# itself is unrelated to packs, so its guard moves here rather than vanishing.
352+
for name in ("release.yml", "dry-run.yml"):
353+
text = (workflows / name).read_text(encoding="utf-8")
354+
if "scripts/ci/extract-release-archives.sh" not in text:
355+
continue
356+
if "$RUNNER_TEMP/release-archives" not in text:
357+
failures.append(
358+
f"{name}: release archives must be downloaded into "
359+
"$RUNNER_TEMP/release-archives, never into the tracked checkout"
360+
)
361+
346362
if failures:
347363
print("VENUE PARITY CONTRACT VIOLATED — one harness, every venue:")
348364
for failure in failures:

0 commit comments

Comments
 (0)