Repository navigation
Commit a700bff
fix(ci): stop kill-grace from bounding Windows helper spawns
The Windows shard failed Step 0i (parallel suite scheduler contract) with
"cleanup failed: hang_after_summary: leader exited leaving live
descendants" while its sibling shard passed the same contract. Nothing in
the wave was actually leaking a process.
run-test-wave.py passed --kill-grace as the subprocess timeout for the two
external Windows helpers: taskkill.exe /T /F and the powershell.exe
Get-CimInstance descendant probe. Those are different quantities.
kill_grace budgets how long a doomed process may take to die; the helpers
also have to pay process spawn plus, for PowerShell, CIM startup. The
contract fixtures run with --kill-grace 1, and one second is not reliably
enough to launch either helper on a loaded runner.
The two timeouts then compounded. A timed-out taskkill is reported as
"could not prove process-tree cleanup", which raises out of the wave loop;
the finally-block cleanup re-enters with the leader already dead, so it
falls to the descendant probe, which times out on the same one-second
budget and takes its "cannot prove absence -> assume the worst" branch.
Phantom descendants, red wave.
Give helper invocations their own floor, max(kill_grace, 30). kill_grace
still governs every actual death wait, so nothing fails open: the
timeout-race contract still refuses with rc=2 over a genuinely surviving
descendant, now because PowerShell answered rather than because it timed
out. The production path already passed --kill-grace 15 and is unchanged
in behaviour.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Tony Thayer-Osborne <tony.thayerosborne@conductorone.com>1 parent 4e8d01d commit a700bff
1 file changed
Lines changed: 14 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
30 | 38 | | |
31 | 39 | | |
32 | 40 | | |
| |||
123 | 131 | | |
124 | 132 | | |
125 | 133 | | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
126 | 138 | | |
127 | 139 | | |
128 | 140 | | |
| |||
167 | 179 | | |
168 | 180 | | |
169 | 181 | | |
170 | | - | |
| 182 | + | |
171 | 183 | | |
172 | 184 | | |
173 | 185 | | |
| |||
185 | 197 | | |
186 | 198 | | |
187 | 199 | | |
188 | | - | |
| 200 | + | |
189 | 201 | | |
190 | 202 | | |
191 | 203 | | |
| |||
0 commit comments