Skip to content

Commit ad010b1

Browse files
authored
Merge pull request #1515 from DeusData/fix/smoke-single-composition
fix(ci): finish the single-composition sweep in the smoke workflow
2 parents 4ed8d38 + 38148b8 commit ad010b1

1 file changed

Lines changed: 13 additions & 17 deletions

File tree

‎.github/workflows/_smoke.yml‎

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,11 @@ jobs:
7171
WIN=$(jq -cn --argjson a "$CORE_WIN" '$a')
7272
PORTABLE=$(jq -cn --argjson a "$CORE_PORTABLE" '$a')
7373
fi
74-
# Keep the UI marker explicit because the smoke wrappers use it to
75-
# require and validate the shipped content-addressed frontend pack.
76-
VARIANTS='["ui"]'
77-
UNIX_M=$(jq -cn --argjson a "$UNIX" --argjson v "$VARIANTS" '{include:[$a[] as $o | $v[] as $t | ($o + {variant:$t})]}')
78-
WIN_M=$(jq -cn --argjson a "$WIN" --argjson v "$VARIANTS" '{include:[$a[] as $o | $v[] as $t | ($o + {variant:$t})]}')
79-
PORTABLE_M=$(jq -cn --argjson a "$PORTABLE" --argjson v "$VARIANTS" '{include:[$a[] as $o | $v[] as $t | ($o + {variant:$t})]}')
74+
# One composition ships; the wrappers assert the embedded UI themselves
75+
# (SMOKE_REQUIRE_UI in scripts/ci/smoke-artifact.sh and below).
76+
UNIX_M=$(jq -cn --argjson a "$UNIX" '{include:$a}')
77+
WIN_M=$(jq -cn --argjson a "$WIN" '{include:$a}')
78+
PORTABLE_M=$(jq -cn --argjson a "$PORTABLE" '{include:$a}')
8079
echo "unix=$UNIX_M" >> "$GITHUB_OUTPUT"
8180
echo "windows=$WIN_M" >> "$GITHUB_OUTPUT"
8281
echo "portable=$PORTABLE_M" >> "$GITHUB_OUTPUT"
@@ -102,9 +101,8 @@ jobs:
102101

103102
- name: Extract release artifact
104103
run: |
105-
SUFFIX=${{ matrix.variant == 'ui' && '-ui' || '' }}
106104
mkdir -p "$RUNNER_TEMP/cbm-artifact"
107-
tar -xzf codebase-memory-mcp${SUFFIX}-${{ matrix.goos }}-${{ matrix.goarch }}.tar.gz \
105+
tar -xzf codebase-memory-mcp-${{ matrix.goos }}-${{ matrix.goarch }}.tar.gz \
108106
-C "$RUNNER_TEMP/cbm-artifact"
109107
chmod +x "$RUNNER_TEMP/cbm-artifact/codebase-memory-mcp"
110108
@@ -116,10 +114,10 @@ jobs:
116114
# the wrapper (no env isolation, no user-PATH guard, fixed port).
117115
- name: Smoke test (shared wrapper)
118116
run: |
119-
scripts/smoke-local.sh \
120-
"$RUNNER_TEMP/cbm-artifact/codebase-memory-mcp" ${{ matrix.variant }}
117+
scripts/smoke-local.sh "$RUNNER_TEMP/cbm-artifact/codebase-memory-mcp"
121118
env:
122119
CBM_SMOKE_ARTIFACT_DIR: ${{ runner.temp }}/cbm-artifact
120+
SMOKE_REQUIRE_UI: "1"
123121

124122
- name: Security audits
125123
run: |
@@ -195,11 +193,10 @@ jobs:
195193
- name: Extract release artifact
196194
shell: msys2 {0}
197195
run: |
198-
SUFFIX=${{ matrix.variant == 'ui' && '-ui' || '' }}
199196
ARCH=${{ matrix.arch }}
200197
ARTIFACT_DIR="$(cygpath -u "$RUNNER_TEMP")/cbm-artifact"
201198
mkdir -p "$ARTIFACT_DIR"
202-
unzip -o "codebase-memory-mcp${SUFFIX}-windows-${ARCH}.zip" -d "$ARTIFACT_DIR"
199+
unzip -o "codebase-memory-mcp-windows-${ARCH}.zip" -d "$ARTIFACT_DIR"
203200
test -s "$ARTIFACT_DIR/codebase-memory-mcp.exe"
204201
# ONE executable per runtime set: a payload sibling would mean the
205202
# removed launcher split came back.
@@ -226,7 +223,7 @@ jobs:
226223
shell: msys2 {0}
227224
env:
228225
SMOKE_ARCH: ${{ matrix.arch }}
229-
SMOKE_VARIANT: ${{ matrix.variant }}
226+
SMOKE_REQUIRE_UI: "1"
230227
run: |
231228
export CBM_SMOKE_ARTIFACT_DIR="$(cygpath -u "$RUNNER_TEMP")/cbm-artifact"
232229
bash test-infrastructure/vm/vm-smoke.sh
@@ -288,9 +285,8 @@ jobs:
288285

289286
- name: Extract release artifact
290287
run: |
291-
SUFFIX=${{ matrix.variant == 'ui' && '-ui' || '' }}
292288
mkdir -p "$RUNNER_TEMP/cbm-artifact"
293-
tar -xzf codebase-memory-mcp${SUFFIX}-linux-${{ matrix.arch }}-portable.tar.gz \
289+
tar -xzf codebase-memory-mcp-linux-${{ matrix.arch }}-portable.tar.gz \
294290
-C "$RUNNER_TEMP/cbm-artifact"
295291
chmod +x "$RUNNER_TEMP/cbm-artifact/codebase-memory-mcp"
296292
@@ -301,10 +297,10 @@ jobs:
301297
# exactly the phases it most needs to run.
302298
- name: Smoke test (shared wrapper)
303299
run: |
304-
scripts/smoke-local.sh \
305-
"$RUNNER_TEMP/cbm-artifact/codebase-memory-mcp" ${{ matrix.variant }}
300+
scripts/smoke-local.sh "$RUNNER_TEMP/cbm-artifact/codebase-memory-mcp"
306301
env:
307302
CBM_SMOKE_ARTIFACT_DIR: ${{ runner.temp }}/cbm-artifact
303+
SMOKE_REQUIRE_UI: "1"
308304

309305
# The -portable binary is what all linux install/update paths now deliver;
310306
# it MUST start on old glibc (Debian 11 / RHEL 8 / Ubuntu 20.04). Runs it

0 commit comments

Comments
 (0)