Repository navigation
Commit f78bfe2
committed
fix: address review feedback on external-import-shadow guard
- specifier_is_relative() now also recognizes Windows drive-letter
(C:\ / C:/) and UNC (\\server\share) specifiers as in-tree, not
external packages. pr-smoke runs this pipeline on Windows, and the
previous POSIX-only check ('.' / '/') classified those specifiers as
external, which could suppress a real edge on that platform only.
Added external_import_shadow_windows_relative_specifier_kept
(tests/test_registry.c): red before this fix, green after.
- old_workers / old_single in the #1355 pipeline test are now
const char*, matching getenv()'s read-only contract.
- The pad_files literal (50) is now a named
EXTERNAL_IMPORT_SHADOW_PARALLEL_PAD constant with a comment tying it
to MIN_FILES_FOR_PARALLEL (a private #define in pipeline.c, not
reachable for a static_assert from tests), so a future bump to that
threshold can't silently drop the fixture back onto the
sequential-only path.
Signed-off-by: Yyunozor <yyunozor@icloud.com>1 parent a3b1db1 commit f78bfe2
3 files changed
Lines changed: 73 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
465 | 466 | | |
466 | 467 | | |
467 | 468 | | |
468 | | - | |
469 | | - | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
470 | 475 | | |
471 | | - | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
472 | 492 | | |
473 | 493 | | |
474 | 494 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4956 | 4956 | | |
4957 | 4957 | | |
4958 | 4958 | | |
| 4959 | + | |
| 4960 | + | |
| 4961 | + | |
| 4962 | + | |
| 4963 | + | |
| 4964 | + | |
| 4965 | + | |
| 4966 | + | |
| 4967 | + | |
| 4968 | + | |
| 4969 | + | |
4959 | 4970 | | |
4960 | 4971 | | |
4961 | 4972 | | |
| |||
5046 | 5057 | | |
5047 | 5058 | | |
5048 | 5059 | | |
5049 | | - | |
| 5060 | + | |
5050 | 5061 | | |
5051 | | - | |
| 5062 | + | |
| 5063 | + | |
| 5064 | + | |
5052 | 5065 | | |
5053 | | - | |
| 5066 | + | |
5054 | 5067 | | |
5055 | 5068 | | |
5056 | 5069 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
990 | 990 | | |
991 | 991 | | |
992 | 992 | | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
| 1005 | + | |
| 1006 | + | |
| 1007 | + | |
| 1008 | + | |
| 1009 | + | |
| 1010 | + | |
| 1011 | + | |
| 1012 | + | |
| 1013 | + | |
| 1014 | + | |
| 1015 | + | |
| 1016 | + | |
| 1017 | + | |
| 1018 | + | |
| 1019 | + | |
| 1020 | + | |
| 1021 | + | |
| 1022 | + | |
| 1023 | + | |
| 1024 | + | |
| 1025 | + | |
993 | 1026 | | |
994 | 1027 | | |
995 | 1028 | | |
| |||
1089 | 1122 | | |
1090 | 1123 | | |
1091 | 1124 | | |
| 1125 | + | |
1092 | 1126 | | |
0 commit comments