Repository navigation
ci(dry-run): add skip_smoke for a direct build → VirusTotal pass - #1490
Merged
Merged
Conversation
Adding the VirusTotal step left one trip unavailable: build straight to the scan. Smoke is in the VirusTotal job's needs, so the only way to reach the scan was to run smoke first — and a smoke failure would withhold precisely the answer such a run was dispatched to get. The skips now cover the three questions worth asking separately: skip_builds no artifacts at all "do lint and tests pass?" skip_smoke build + scan, no smoke "does this diff scan red?" skip_virustotal build + smoke + soak, no scan "do the archives pass CI?" skip_smoke is for the case where the scan verdict is the entire point: the last release scanned clean, so the question is only whether the accumulated diff turns it red. Everything between build and the scan is cost without information for that question. VirusTotal keeps smoke and soak in its needs, and that is deliberate: they order the job last, they do not gate it. A SKIPPED smoke leaves the scan reachable (result 'skipped', which is not 'failure'); a FAILED smoke still withholds it, because a verdict on artifacts already known to be broken is not worth two hours of polling. The release-gate-chain contract covers exactly this distinction — an optional phase must not silently disable the phases after it — and passes. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1489. Adding the VirusTotal step left one trip unavailable: build straight to the scan.
Smoke sits in the VirusTotal job's
needs, so the only way to reach the scan was to run smoke first — and a smoke failure would withhold precisely the answer such a run was dispatched to get.The three skips now cover three separate questions
skip_buildsskip_smokeskip_virustotalskip_smokeis for the case where the scan verdict is the point: the last release scanned clean, so the only question is whether the accumulated diff turns it red. Everything between build and the scan is cost without information for that question.Skipped vs failed — the distinction that matters
VirusTotal keeps
smokeandsoakin itsneeds, deliberately. They order the job last; they don't gate it:result == 'skipped', which is not'failure')tests/test_release_gate_chain_contract.shexists to catch exactly the error of an optional phase silently disabling the phases after it. It passes, as do the venue-parity and exec-bit contracts.Scope
dry-run.ymlisworkflow_dispatch-only — nothing here runs on PRs or pushes. Workflow-file change only; no scripts, no product code.