Repository navigation
fix(install): accept legacy archives without cbm-integrations.json - #1505
michaelxer wants to merge 2 commits into
Conversation
Published v0.9.0 Windows/Unix release archives still ship the four-file core layout and omit cbm-integrations.json. Main install.ps1/install.sh required the five-file layout after runtime assets were externalized, so raw.githubusercontent.com installers fail on current latest downloads with "archive must contain exactly one cbm-integrations.json". Accept either the legacy four-file core set or the current five-file set (and the matching UI +1 pack). package-release.sh still ships the integration manifest for new builds. Add a focused layout-compat test. Fixes DeusData#1499 Signed-off-by: michaelxer <michaelxer@users.noreply.github.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
The install scripts now accept both the legacy four-file core layout and the current five-file layout. Update the smoke fixture static assertions to match EXPECTED_CORE_COUNT rather than hard-coded EXPECTED_MEMBER_COUNT=5/6 so Step 0h no longer fails the dual-accept installer change. Signed-off-by: michaelxer <michaelxer@users.noreply.github.com>
87436ee to
0391040
Compare
|
Closing this one. After #1508 re-embedded runtime assets, Leaving #1499 for maintainers to close or retarget if anything still fails on a fresh install from |
|
Superseded by the #1508 re-embed on main (installers no longer require cbm-integrations.json). |
Summary
Fixes #1499.
Published v0.9.0 Windows/Unix release archives still ship the four-file core layout and omit
cbm-integrations.json. After runtime assets were externalized onmain,install.ps1/install.shfromraw.githubusercontent.com/.../mainrequire the five-file layout, so installers fail against currentlatestdownloads with:I reproduced this against the live v0.9.0 assets:
codebase-memory-mcp-windows-amd64.zipentries:codebase-memory-mcp.exe,LICENSE,install.ps1,THIRD_PARTY_NOTICES.md(nocbm-integrations.json)codebase-memory-mcp-linux-amd64.tar.gzentries: same four-file core layoutSolution
cbm-integrations.json).scripts/package-release.shis unchanged and still shipscbm-integrations.jsonfor new builds.Verification
Also checked the live v0.9.0 member lists against the new acceptance matrix (legacy 4-file and current 5-file both pass; incomplete/extra/duplicate still fail).
Limitations
cbm-integrations.jsonis published, both layouts remain valid; new archives should keep shipping the integration manifest viapackage-release.sh.Checklist
scripts/test.sh/ ASan suite (not run — installer-only change)