Repository navigation
fix(ci): finish the single-composition sweep in the smoke workflow - #1515
Merged
Merged
Conversation
The first full dry run after #1508 failed in all three smoke-linux-portable legs: _smoke.yml still expanded a variant matrix and extracted codebase-memory-mcp-ui-<os>-<arch>.tar.gz — a name the build no longer produces. PR CI never sees this job (pr.yml calls the smoke wrappers directly), so the miss only surfaced in the dry-run/release path this workflow serves. The matrix loses its variant dimension, all three legs extract the unsuffixed archive, and the positional/SMOKE_VARIANT plumbing is replaced by SMOKE_REQUIRE_UI=1: these legs smoke the SHIPPED artifact, so a binary serving no embedded UI is a defect here, exactly like scripts/ci/smoke-artifact.sh. Verified locally: venue-parity and smoke-fixture contracts pass; YAML parses. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first full dry run after #1508 failed in all three
smoke-linux-portablelegs:_smoke.ymlstill expanded a variant matrix and extractedcodebase-memory-mcp-ui-<os>-<arch>.tar.gz— a name the build no longer produces. PR CI never exercises this job (pr.ymlcalls the smoke wrappers directly), so the miss only surfaced in the dry-run/release path.SMOKE_VARIANT/ positional variant plumbing becomesSMOKE_REQUIRE_UI=1: these legs smoke the shipped artifact, so a binary serving no embedded UI is a defect here, mirroringscripts/ci/smoke-artifact.sh.Workflows-only change. Verified locally: venue-parity and smoke-fixture contracts pass; YAML parses. Dry run 31357346999 was cancelled at the first failing job and will be re-dispatched once this lands.