Skip to content

docs(cli): list daemon <start|stop|status> in --help - #2443

Merged
DeusData merged 4 commits into
DeusData:mainfrom
bmcnaboe:docs/help-daemon-subcommand
Oct 26, 2026
Merged

DeusData merged 4 commits into
DeusData:mainfrom
bmcnaboe:docs/help-daemon-subcommand

Conversation

@bmcnaboe

Copy link
Copy Markdown
Contributor

What does this PR do?

Lists daemon <start|stop|status> in --help. The subcommand was reachable but absent from the usage text. The description matches the hint daemon status already prints: a warm daemon lets CLI calls and hooks skip the per-command daemon start-up. It does not claim to remove a hook process's own image hash.

Split out of #1767 at review.

Checklist

  • Every commit is signed off (git commit -s)
  • src/main.c compiles clean with -Wall -Wextra -Werror and clang-format --dry-run --Werror passes; no behaviour change, so the suites were not rerun for this branch
  • Lint passes (clang-format)
  • New behavior is covered by a test — help text only, no test

The daemon subcommand was reachable but absent from the usage text. The
description matches the hint daemon status already prints: a warm daemon
lets CLI calls and hooks skip the per-command daemon start-up. It does
not claim to remove a hook process's own image hash.

Signed-off-by: Brian McNaboe <bmcnaboe@gmail.com>
@github-actions

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

@DeusData DeusData added documentation Improvements or additions to documentation ux/behavior Display bugs, docs, adoption UX priority/normal Standard review queue; useful PR with ordinary maintainer urgency. labels Oct 1, 2026
@DeusData

DeusData commented Oct 1, 2026

Copy link
Copy Markdown
Owner

Thank you for splitting out this small help-text change and keeping its claim precise. The daemon subcommand is already handled in src/main.c, so this is tagged as documentation/discoverability rather than a new daemon feature. The review queue is currently full, so a complete review may take a little time. Thank you for your patience and for helping improve the project; this acknowledgement is not yet an approval or a merge commitment.

@DeusData

Copy link
Copy Markdown
Owner

Thanks again for the focused daemon help-text addition split from #1767. It remains pending review; no new change is requested by this sweep.

Hooks never start a daemon. Without one they skip graph augmentation
and print a throttled notice that points at `daemon start`
(main_hook_report_absent_daemon), so a hook has no per-command daemon
start-up to skip. What a warm daemon gives hooks is the graph context
itself. Reword the second half of the daemon help entry to say that.

The CLI half stays: it matches the hint a one-shot CLI command prints
after it had to start a temporary daemon.

Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
@DeusData

Copy link
Copy Markdown
Owner

Thank you, @bmcnaboe, for splitting this out of #1767 exactly as the review asked, and for keeping the claim narrow. daemon <start|stop|status> is a real subcommand that had no line in --help, so this closes a genuine discoverability gap. The CLI half of your description matches the hint the binary itself prints after it had to start a temporary daemon.

We pushed one small commit on top of yours (maintainer edits are enabled, thank you for that). Nothing of yours was rewritten:

  1. Hooks wording. Hooks never start a daemon themselves. Without one they skip graph augmentation and print a notice that points at daemon start. So a hook has no per-command start-up to skip; what a warm daemon gives hooks is the graph context itself. The entry now reads:

codebase-memory-mcp daemon <start|stop|status>
start keeps a daemon warm: CLI calls skip
the per-command start-up, and hooks add
graph context only while a daemon runs

We built the binary from your branch merged with current main plus this commit and checked the --help output. The entry lines up with its neighbours and stays within 80 columns, like your original. CI will run on the new head.

Thanks again for the careful split, and for your patience while this waited in the queue.

@DeusData

Copy link
Copy Markdown
Owner

Thank you again for the focused daemon-help addition. The October 20 update records the hook wording correction and help-output check as completed. The remaining follow-up is ours; sorry for the delay, and I’ll follow up soon.

Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
@DeusData

Copy link
Copy Markdown
Owner

Thank you again, @bmcnaboe, for this focused help-text addition. We merged the current main into your branch (one signed-off merge commit, 5f0f862) so CI runs against today's tree. The earlier red checks came from a repository-wide contract on published documentation counts, which has since been repaired on main; none of it was caused by your change, and nothing of yours was rewritten. If you push again, please pull first. Once the checks are green, this is ready to land.

@DeusData
DeusData merged commit 9e7794b into DeusData:main Oct 26, 2026
34 checks passed
@DeusData

Copy link
Copy Markdown
Owner

Merged as 9e7794b - thank you, @bmcnaboe! The daemon subcommand was easy to miss because --help never mentioned it, and your two lines on what a warm daemon actually gives (faster CLI calls, and graph context in hooks only while it runs) answer the question people ask right after finding it. Thank you for the clear, focused change and for your patience while it waited in the queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation priority/normal Standard review queue; useful PR with ordinary maintainer urgency. ux/behavior Display bugs, docs, adoption UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants