Repository navigation
docs(cli): list daemon <start|stop|status> in --help - #2443
Conversation
The daemon subcommand was reachable but absent from the usage text. The description matches the hint daemon status already prints: a warm daemon lets CLI calls and hooks skip the per-command daemon start-up. It does not claim to remove a hook process's own image hash. Signed-off-by: Brian McNaboe <bmcnaboe@gmail.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
|
Thank you for splitting out this small help-text change and keeping its claim precise. The daemon subcommand is already handled in src/main.c, so this is tagged as documentation/discoverability rather than a new daemon feature. The review queue is currently full, so a complete review may take a little time. Thank you for your patience and for helping improve the project; this acknowledgement is not yet an approval or a merge commitment. |
|
Thanks again for the focused daemon help-text addition split from #1767. It remains pending review; no new change is requested by this sweep. |
Hooks never start a daemon. Without one they skip graph augmentation and print a throttled notice that points at `daemon start` (main_hook_report_absent_daemon), so a hook has no per-command daemon start-up to skip. What a warm daemon gives hooks is the graph context itself. Reword the second half of the daemon help entry to say that. The CLI half stays: it matches the hint a one-shot CLI command prints after it had to start a temporary daemon. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
|
Thank you, @bmcnaboe, for splitting this out of #1767 exactly as the review asked, and for keeping the claim narrow. We pushed one small commit on top of yours (maintainer edits are enabled, thank you for that). Nothing of yours was rewritten:
codebase-memory-mcp daemon <start|stop|status> We built the binary from your branch merged with current Thanks again for the careful split, and for your patience while this waited in the queue. |
|
Thank you again for the focused daemon-help addition. The October 20 update records the hook wording correction and help-output check as completed. The remaining follow-up is ours; sorry for the delay, and I’ll follow up soon. |
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
|
Thank you again, @bmcnaboe, for this focused help-text addition. We merged the current main into your branch (one signed-off merge commit, 5f0f862) so CI runs against today's tree. The earlier red checks came from a repository-wide contract on published documentation counts, which has since been repaired on main; none of it was caused by your change, and nothing of yours was rewritten. If you push again, please pull first. Once the checks are green, this is ready to land. |
|
Merged as 9e7794b - thank you, @bmcnaboe! The daemon subcommand was easy to miss because --help never mentioned it, and your two lines on what a warm daemon actually gives (faster CLI calls, and graph context in hooks only while it runs) answer the question people ask right after finding it. Thank you for the clear, focused change and for your patience while it waited in the queue. |
What does this PR do?
Lists
daemon <start|stop|status>in--help. The subcommand was reachable but absent from the usage text. The description matches the hintdaemon statusalready prints: a warm daemon lets CLI calls and hooks skip the per-command daemon start-up. It does not claim to remove a hook process's own image hash.Split out of #1767 at review.
Checklist
git commit -s)src/main.ccompiles clean with-Wall -Wextra -Werrorandclang-format --dry-run --Werrorpasses; no behaviour change, so the suites were not rerun for this branchclang-format)