Repository navigation
fix(discover): map jinja and jinja2 in userconfig language table - #2568
Conversation
Signed-off-by: Totopo27 <35828647+Totopo27@users.noreply.github.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
|
Thanks for the focused jinja/jinja2 configuration alias fix and the link to #2563. I have read the description; this is queued for review with the local test and lint results still marked incomplete. |
|
Updated the checklist in the PR description to reflect the passing test and lint runs. Thanks for queuing the review! |
|
Thank you, @Totopo27! This is exactly the right fix: lang_from_string() had no name for the Jinja2 grammar that was already built in, so an extra_extensions mapping like {".html": "jinja2"} was silently dropped. We verified it end to end on the Flask repository and on the reproduction from #2563: with this change, mapped .html files are parsed with the Jinja2 grammar exactly like native .jinja2 files, the "jinja" alias lines up with the existing .jinja extension, and indexes without a config are unchanged. Thanks also for extending the existing userconfig test rather than adding a parallel one, and for updating the checklist. Merged! |
What does this PR do?
Add
jinjaandjinja2aliases toLANG_NAME_TABLEinsrc/discover/userconfig.c.Resolves #2563.
Configuring
"extra_extensions": {".html": "jinja2"}in.codebase-memory.jsonwas previously ignored becauselang_from_string()had no entry for Jinja2, returningCBM_LANG_COUNTeven thoughCBM_LANG_JINJA2and its grammar were present in the build.Checklist
git commit -s) — required, CI rejects unsigned commits (DCO, see CONTRIBUTING.md)make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)