Skip to content

fix(parser): keep valid TypeScript import arrays complete - #2594

Open
lorenzozanee wants to merge 1 commit into
DeusData:mainfrom
lorenzozanee:fix/typescript-import-type-array
Open

lorenzozanee wants to merge 1 commit into
DeusData:mainfrom
lorenzozanee:fix/typescript-import-type-array

Conversation

@lorenzozanee

@lorenzozanee lorenzozanee commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

A valid TypeScript import("./types").Order[] type inside a generic call was counted as a parse error. This narrowly recognizes that recovery shape while continuing to count other recovery errors.

The regression test covers the reported ASCII single-property form and malformed near-matches. Valid Unicode identifiers, trivia-separated tokens, and additional properties remain uncovered. The focused extraction suite passed (435 tests). The full Makefile test target was not run, and scripts/lint.sh --ci could not complete because cppcheck is missing and clang-format is unavailable.

Prepared with an AI agent on behalf of the account owner, who is responsible for this contribution.

Fixes #2576

Checklist

  • Every commit is signed off (git commit -s) — required, CI rejects unsigned commits (DCO, see CONTRIBUTING.md)
  • Tests pass locally (make -f Makefile.cbm test)
  • Lint passes (make -f Makefile.cbm lint-ci)
  • New behavior is covered by a test (reproduce-first for bug fixes)

Signed-off-by: lorenzozanee <wyz0707@proton.me>
@github-actions

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

@DeusData DeusData added bug Something isn't working parsing/quality Graph extraction bugs, false positives, missing edges labels Oct 19, 2026
@DeusData

Copy link
Copy Markdown
Owner

Thanks for the TypeScript import-array recovery fix and for explicitly listing the uncovered valid forms. I have read the description and focused result; the narrow recognition and remaining Unicode/trivia/property cases are points for review. This remains pending review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working parsing/quality Graph extraction bugs, false positives, missing edges

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript: import('…').T[] inside a generic call's type argument marks a valid file parse_partial and drops later declarations

2 participants