Repository navigation
fix(parser): keep valid TypeScript import arrays complete - #2594
lorenzozanee wants to merge 1 commit into
Conversation
Signed-off-by: lorenzozanee <wyz0707@proton.me>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
|
Thanks for the TypeScript import-array recovery fix and for explicitly listing the uncovered valid forms. I have read the description and focused result; the narrow recognition and remaining Unicode/trivia/property cases are points for review. This remains pending review. |
What does this PR do?
A valid TypeScript
import("./types").Order[]type inside a generic call was counted as a parse error. This narrowly recognizes that recovery shape while continuing to count other recovery errors.The regression test covers the reported ASCII single-property form and malformed near-matches. Valid Unicode identifiers, trivia-separated tokens, and additional properties remain uncovered. The focused extraction suite passed (435 tests). The full Makefile test target was not run, and
scripts/lint.sh --cicould not complete becausecppcheckis missing andclang-formatis unavailable.Prepared with an AI agent on behalf of the account owner, who is responsible for this contribution.
Fixes #2576
Checklist
git commit -s) — required, CI rejects unsigned commits (DCO, see CONTRIBUTING.md)make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)