Skip to content

ci(pages): skip deployment in unconfigured forks - #2615

Open
ankitbuilds99 wants to merge 2 commits into
DeusData:mainfrom
ankitbuilds99:fix/pages-fork-guard
Open

ankitbuilds99 wants to merge 2 commits into
DeusData:mainfrom
ankitbuilds99:fix/pages-fork-guard

Conversation

@ankitbuilds99

Copy link
Copy Markdown

Summary

Fixes fork push CI when GitHub Pages is not configured.

The Deploy Pages workflow currently runs actions/configure-pages for every push to main. In forks without a Pages site, that action fails with:

Get Pages site failed ... Not Found

This adds a repository guard so deployment runs only in the canonical DeusData/codebase-memory-mcp repository. The upstream Pages deployment remains unchanged; forks skip this repository-owned deployment instead of reporting a false CI failure.

Observed in fork run 38325069400.

Validation

  • Verified the generated workflow contains the repository guard.
  • DCO and OpenSSF checks passed on the affected fork push.
  • The change is limited to .github/workflows/pages.yml.

@github-actions

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

@ankitbuilds99

Copy link
Copy Markdown
Author

@DeusData — this PR fixes the Pages CI failure observed in fork run 38325069400. It guards deployment to the canonical repository, so forks without Pages enabled no longer fail at configure-pages while upstream deployment remains unchanged. Please review and merge when convenient. Thank you!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant