@@ -2,15 +2,15 @@
 
 # Unit Tests Practice
 
-#### This repository has been prepared to practice the `unittest` automated testing framework through different angles
+#### This repository has been prepared to practice the `unittest` automated testing framework
 #### It is based on the use of simple quizzes importer and viewer.
 
 ---
 
 ## questionnaire_import.py
 >python ./questionnaire_import.py 
 
-Loads some quizzes from a sample list in the program and converts them into a specific json [format](./questionnaire.md#expected-json-schema) before to save them 
+Loads some quizzes from a sample list in the program and converts them into a specific [json format](./questionnaire.md#expected-json-schema) before to save them 
 into the [json_questionnaires](./json_questionnaires) folder
 
 More info : [questionnaire_import.md](./questionnaire_import.md)
@@ -20,7 +20,7 @@ More info : [questionnaire_import.md](./questionnaire_import.md)
 ## questionnaire.py
 >python ./questionnaire.py <questionnaire.json>
 
-Displays the quizz in argument and counts the number of good answers
+Displays the quiz in argument and counts the number of good answers
 
 More info : [questionnaire.md](./questionnaire.md)
 
@@ -33,11 +33,12 @@ Uses the `unittest` automated framework but not only to test questionnaire.py
 
 More info : [questionnaire_unit_test.md](./questionnaire_unit_test.md)
 
-Uses : 
-- initial_json_test_file.json
-- second_json_test_file.json
-- json_file_without_extension
-- empty.json
+Uses the files: 
+- json_00_empty.json
+- json_00_without_extension
+- json_01_good_format.json
+- json_01_another_good_format.json
+- pytest.ini
 
 and files into [json_test_files](./json_test_files) folder
 
 
@@ -2,7 +2,7 @@
 
 # Questionnaire.py
 
-Displays the quizz in argument and counts the number of good answers
+Displays the quiz in argument and counts the number of good answers
 
 ```commandline
 python questionnaire.py <questionnaire.json>
@@ -14,11 +14,12 @@ python questionnaire.py <questionnaire.json>
 python questionnaire.py .\json_questionnaires\animaux_leschats_confirme.json
 ```
 ```commandline
+=== QUESTIONNAIRE ===
 Catégorie : Animaux
 Difficulté : confirmé
-Titre : Les chats
+Titre : Les Chats
 
-QUESTION 1
+QUESTION 1/20
   À quelle classe d'animaux vertébrés regroupant près de 5.400 espèces appartient le chat ?
    1 - Mammifères
    2 - Reptiles
@@ -39,22 +40,24 @@ Questionnaire.py can accept a json file from :
 * an URL
 
 Questionnaire.py tries to load the json file in argument or print :
-- [```Error in argument```] if no one or more than one argument is passed
-- [```Incorrect extension```] if the file as no json extension 
-- [```Invalid Path```] if the path to the file can not be reached  
-- [```No File```] if the file can not be find into the path folder 
-- [```Invalid URL```] if the path to the server can not be reached  
-- [```File not found```] if the file can not be reached on the distant server
-- [```Incompatible or no data in JSON file```] if the json file cannot be loaded and decoded
-- [```Incompatible Json schema```] if the loaded json file does not match the expected schema
-- [```The title of the quizz is missing```] if the ```titre``` property is an empty string
-
-These messages may also be printed but are **not critical** for the quiz
-- [```Skipped question : nothing to ask in question```] if the ```titre``` property of question is an empty string
-- [```Skipped question : no one or more than one good answer in question```] if a question has no one or more than 
-one ```boolean```  at ```True``` in its possible answers
-
-At least, if all questions have been skipped, [```No compatible question in this quizz```] will be printed.
+- [`Error in argument`] if __no one or more than one argument is passed__
+- [`Incorrect extension`] if __the file as no json extension__ 
+- [`Invalid permissions or path`] if __the path to the file can not be reached__  
+- [`Invalid permissions or path`] if __the system has not the permission to open the file__  
+- [`Invalid URL`] if __the path to the server can not be reached__  
+- [`File not found`] if __the file can not be reached on the distant server__
+- [`Incompatible or no data in JSON file`] if __the json file cannot be loaded and decoded__
+- [`Incompatible Json schema`] if __the loaded json file does not match the expected schema__
+- [`The title of the quizz is missing and mandatory`] if __the `titre` property is an empty string__
+- [`The questions of the quizz are missing and mandatory`] if __the `questions` property is an empty array__
+
+These warnings may also be printed but are __not critical__ to use the quiz
+- [`Skipped question : question is empty`] if __the `titre` property of a question is an empty string__
+- [`Skipped answer : answer is empty`] if __the first parameter of a `choix` in a question is an empty string__
+- [`Skipped question : no one or more than one good answers`] if a question has no one or more than one `boolean` 
+at `true` in the possible answers of a single question
+
+At least, if all questions have been skipped, [`Désolé, aucune question n'est compatible avec ce quizz`] will be printed.
 
 ---
 ## Expected Json Schema
@@ -68,38 +71,52 @@ a ```boolean``` only
 
 ```json lines
 schema = {
-    "$schema": "http://json-schema.org/draft/2020-12/schema",
-    "type": "object",
-    "required": [ "titre", "questions" ],
-    "properties": {
-        "categorie": {"type": "string"},
-        "titre": {"type": "string"},
-        "questions": {
-            "type": "array",
-            "default": [],
-            "items": {
-                "type": "object",
-                "required": ["titre","choix"],
-                "properties": {
-                    "titre": {"type": "string"},
-                    "choix": {
-                        "type": "array",
-                        "minItems": 2,
-                        "items": {
+        "$schema": "https://json-schema.org/draft/2020-12/schema",
+        "$id": "https://json-schema.org/draft/2020-12/schema",
+        "type": "object",
+        "required": ["titre", "questions"],
+        "properties": {
+            "categorie": {"type": "string"},
+            "titre": {"type": "string"},
+            "questions": {
+                "type": "array",
+                "default": [],
+                "items": {
+                    "type": "object",
+                    "required": ["titre", "choix"],
+                    "properties": {
+                        "titre": {"type": "string"},
+                        "choix": {
                             "type": "array",
                             "minItems": 2,
-                            "prefixItems": [
-                                {"type": "string"}, 
-                                {"type": "boolean"}
-                            ],
-                            "items": false
+                            "items": {
+                                "type": "array",
+                                "minItems": 2,
+                                "prefixItems": [
+                                  {"type": "string"}, 
+                                  {"type": "boolean"}
+                                ],
+                                "items": False
+                            }
                         }
                     }
                 }
-            }
-        },
-        "difficulte": {"type": "string"}
+            },
+            "difficulte": {"type": "string"}
+        }
     }
 }
 ```
+Note : The `json-schema.org/draft/2020-12/` allows the `prefixItems` property to specify the types of the first 
+items into this part and accepts to define `items` at false to mean that nothing more than the prefix items can be 
+added into this part. This is however not supported by `json-schema.org/draft/2019-09/` used by a lot of json 
+validator online.
 
+Therefore, it is necessary to specify `[]` in place of `False` into the last `items` property to test
+the json files into json validator using `json-schema.org/draft/2019-09/`. The type of prefixItems can unfortunatly be 
+verified by the schema with `json-schema.org/draft/2020-12/` only.
+
+Sample : https://www.jsonschemavalidator.net/s/fhyE6WC0
+
+
+[README.md](./README.md) > [questionnaire.md](./questionnaire.md)
@@ -100,11 +100,15 @@ class Questionnaire:
                         "titre": {"type": "string"},
                         "choix": {
                             "type": "array",
+                            "default": [],
                             "minItems": 2,
                             "items": {
                                 "type": "array",
                                 "minItems": 2,
-                                "prefixItems": [{"type": "string"}, {"type": "boolean"}],
+                                "prefixItems": [
+                                    {"type": "string"},
+                                    {"type": "boolean"}
+                                ],
                                 "items": False
                             }
                         }
 
@@ -8,12 +8,12 @@ Loads some quizzes from a sample list in the program :
 * openquizzdb_241.json
 * openquizzdb_90.json
 
-and converts them into a specific json [format](./questionnaire.md#expected-json-schema) before to save them 
+and converts them into a specific [json format](./questionnaire.md#expected-json-schema) before to save them 
 into the [json_questionnaires](./json_questionnaires) folder
 
 Those quizzes were initially downloaded from http://www.openquizzdb.org/ or https://www.kiwime.com/oqdb/files/ but the 
-API that allowed to do it for free has been disconnected and is no longer available.\
-Those quizzes have thus been transferred on www.codeavecjonathan.com to be manipulated through this exercise
+API which allowed to do it for free has been disconnected and is no longer available.\
+Those quizzes have thus been transferred on www.codeavecjonathan.com to be manipulated through this exercise.
 
 
 ### Sample of the initial json quiz format :
@@ -69,20 +69,20 @@ Those quizzes have thus been transferred on www.codeavecjonathan.com to be manip
     }
 }
 ```
-Each json quiz has 3 categories of difficulty : ```débutant```, ```confirmé``` or ```expert``` 
-( beginner, advanced or expert )
+Each json quiz has 3 categories of difficulty : `débutant`, `confirmé` or `expert` 
+*[ beginner, advanced or expert ]*
 
-Each category includes 10 questions with 4 possible answers to be offered to the user.
+Each category includes 10 questions with 4 answer choices to be offered to the user.
 
-The good answer can be found in the ```réponse``` key. 
+The good answer can be found under the `réponse` key. 
 ___
 ### How to use it :
 
 > python questionnaire_import.py
 
-loads json quiz files and converts them into a new json format by creating one file per difficulty category
+loads json quizzes and converts them to a new json format by creating one file per difficulty category.
 
-### Sample of the json quizz format after import :
+### Sample of the json quiz format after import :
 ```json
 {
   "categorie" : "Animaux",
@@ -114,4 +114,7 @@ These last ones are compiled to have 4 propositions with a boolean parameter
 indicating if the answer is the good one. 
 
 ---
-### The schema must so match with the [expected jdon schema](./questionnaire.md#expected-json-schema) of [./questionnaire.py](./questionnaire.md)
+### The schema must so match with the [expected json schema](./questionnaire.md#expected-json-schema) of [./questionnaire.py](./questionnaire.md)
+
+
+[README.md](./README.md) > [questionnaire_import.md](./questionnaire_import.md)