fix(arraystore): Fix arraystore behaviour for collection like fields (T1334552) - #34991
Open
ajivanyandev wants to merge 2 commits into
Open
fix(arraystore): Fix arraystore behaviour for collection like fields (T1334552)#34991ajivanyandev wants to merge 2 commits into
ajivanyandev wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes ArrayStore push-update behavior when records contain collection-like fields (e.g., Set/Map) by preventing “broken clones” during deep-extend/cloning operations and adding coverage to catch regressions.
Changes:
- Add
isCollectionLikedetection and treatSet/Map/weak collections as assign-by-reference indeepExtendArraySafe. - Avoid cloning collection-like instances during
ArrayStoreimmutable update cloning. - Add regression tests in both QUnit (ArrayStore) and Jest (object utils).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.data/storeArray.tests.js | Adds a QUnit regression test verifying push(update) keeps Set fields usable after update. |
| packages/devextreme/js/__internal/data/m_array_utils.ts | Skips cloning for collection-like instances during immutable update preparation. |
| packages/devextreme/js/__internal/core/utils/m_object.ts | Introduces isCollectionLike and updates deep-extend logic to return collection-like objects by reference. |
| packages/devextreme/js/__internal/core/utils/tests/m_object.test.ts | Adds Jest coverage ensuring Set/Map are assigned by reference (not cloned/broken). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+17
to
+20
| const isCollectionLike = function (value: unknown): boolean { | ||
| return value instanceof Set || value instanceof Map | ||
| || value instanceof WeakSet || value instanceof WeakMap; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.