Repository navigation
Fix rtutcp initialization for pymodbus 3.x (remove deprecated method kwarg) - #1
Open
richardapeters wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes RTU-over-TCP setup failure caused by passing method="rtu" to AsyncModbusSerialClient, which is not accepted in newer pymodbus versions.
Problem
Users configuring rtutcp hit:
AsyncModbusSerialClient.init() got an unexpected keyword argument 'method'
The integration currently sets:
In current pymodbus APIs, AsyncModbusSerialClient already implies RTU framing, so method is unnecessary and invalid.
Change
In custom_components/deye_modbus/coordinator.py:
Why this works
AsyncModbusSerialClient determines RTU behavior by client type.
socket://... selects socket transport for serial-style RTU frames (RTU-over-TCP tunnel).
Impact