Repository navigation
Conversation
… writes with polling, surface write failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On my SUN-12K-SG05LP3 (via the Deye WiFi/LAN logger, port 8899), all control
entities (number/select/switch) fail to write. The integration sends FC06
(Write Single Register), which the inverter silently ignores. pymodbus logs
"No response received after 3 retries", the entity briefly goes unavailable and
the value never changes. Writing the same register via the
deye_modbus.write_registersservice (FC16) works immediately.Deye's Modbus protocol document specifies FC16 (0x10) for writes.
Changes
fc16default /fc06legacy).write_single_register()sends FC16 with one value when
fc16is selected, so all existing controlentities work without map changes.
could interleave with a running poll on the shared connection (transaction_id
mismatches, lost writes).
entities raise
HomeAssistantErrorso failures are visible in the UI/traces._write_call().write_registerservice stays explicitly FC06 (as documented); description updated.Testing
number.set_value,confirmed via the RB readback sensor; no timeouts.
fc16 → write succeeds; fc06 → logged failure, returns False.