Repository navigation
ci: run the pre-commit hooks as CI's lint job - #49
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e24c91af0b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
f854f73 to
a3b5e1e
Compare
What & why
CI's lint job and
.pre-commit-config.yamlran different checks at different versions, so CI never ran codespell, mdformat, actionlint or the hygiene hooks, and a commit never ran sqlfluff. The pre-commit config is now the one definition, and CI runs every hook on every file.Closes #24
Changes
uv run, like ty, so all three run at theiruv.lockversions. The ruff hooks pass--force-exclude, as the remote ones did.dbt/models/. It readsDUCKDB_PATHfrom.envlocally. In CI,UV_NO_ENV_FILEmakes uv ignore the missing.envand the job setsDUCKDB_PATH.pre-commit run --all-files --show-diff-on-failure, with the hook environments cached on the config's hash. A hook that rewrites a file fails the job and prints the diff.docs/one/conversion_tables/transformations.mdis rewrapped so no line starts with1999), which mdformat would otherwise escape as1999\). The file is the provenance'sdataTransformationDescription, so the escape would have reached the MCF.b"caf\xe9\n"intests/dfo/skills/test_assets.pycarries# codespell:ignore caf, so codespell no longer rewrites it tocalf.Notes for reviewers
run:scripts. On the ubuntu runner it will, so the first CI run is that check.pre-commit autoupdatedoesn't touch the local hooks. Their versions move withuv lock --upgrade.Checklist
🤖 Generated with Claude Code