Repository navigation
ci: fail on a stale uv.lock instead of re-locking - #52
Merged
Merged
Conversation
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
CI's
uv runcalls re-lock wheneveruv.lockis stale againstpyproject.toml, so a stale lock would pass CI, and the hooks would run ruff, ty and sqlfluff at freshly resolved versions rather than the locked ones. SettingUV_LOCKEDmakes every uv command in CI use the lock as committed and fail if it is stale.Follow-up to #24.
Changes
UV_LOCKED: "1"at workflow level, covering the pre-commit hooks'uv runcalls as well as the job steps.uv sync --frozenbecomesuv syncin both jobs, since uv rejects--frozenalongsideUV_LOCKED.check-added-large-filesgives its limit as 5MB, matching--maxkb=5000.Notes for reviewers
pyproject.tomlgiven a dependency missing fromuv.lock, bothuv syncanduv runfail with "The lockfile atuv.lockneeds to be updated". The full lint and test jobs pass withUV_LOCKED=1on this branch.Checklist
🤖 Generated with Claude Code