Repository navigation
feat(registry): map every Presentation route and state where a frame refusal lands - #39
Merged
Merged
Conversation
…rame.rows read them
…he canonical byte stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Presentation API now maps every route it serves.
presentation.framescovers both frames routes,presentation.component_readthe component GET, andpresentation.component_datathe revision data route. Until now these routes had no endpoint, so apis checked them againstpresentation.writeas a stand-in. Meta routes stay unmapped.unsupported_schema_versionmaps at 422 onpresentation.renderandpresentation.shares, where a request body carryingschema_versionalready answers that code.Three definitions now state where a frame refusal lands. A store that fails to answer is
service_unavailableat 503. A pin of a derived frame with no recipe yet isframe_unavailableat 404, retryable, withcause.coderecipe_pending. A pin of a derived frame whose recipe cannot be read isinternal_errorat 500, since recipes are write-once.release_mismatchadds a read of a stored payload whose shape the release does not recognise. The[Unreleased]changelog text that put a failed store read underframe_unavailableat 503 is corrected.No code is added, so the apis bijection holds. DevelopmentFinanceObservatory/apis#75 moves its pin to this commit and reads every Presentation status from the registry.
Testing: tools 618, spec-kit 259, components 314, and client-contract 244 passed, and all 8 validators report OK. Dropping the endpoints from the schema's doors-forbidden list fails three new rows in
tools/tests/test_validate_registry.py.