Repository navigation
registry: map internal_error on datasets.pin at 500 - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal_errornow maps ondatasets.pinat 500, inregistries/codes.jsonand its packaged copy.dfo-apis answers
CallerUnresolvedas a non-retryableinternal_error500 on every door. Each of its causes is a deployment fault a retry does not clear: a principal mismatch, an unsetDFO_CALLER_HMAC_KEY, or a missing or bad trustedX-Forwarded-Forentry. The Datasets doors answered it asservice_unavailable503 withretryable: false, which contradicts that code's definition ("a retry is expected to succeed").internal_erroralready maps at 500 ondatasets.exports,datasets.export_link,presentation.writeandpresentation.shares;datasets.pinwas the one door without it.Testing:
validate_registrypasses (265 entries), and the spec-kit (450) and dfo-spec-kit-components (314) tests pass.