Repository navigation
fix(registry): retire entities_unbound and drop Datasets mappings no route raises - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registry mapped six codes to Datasets endpoints whose routes never raise them, and kept
entities_unboundactive although nothing raises it anywhere. dfo-apis lists those mappings as registered but unraised intests/platform/test_registry_binding.py; with this change that list is empty.entities_unboundisretiredinregistries/codes.jsonand its bundled mirror. A mint that binds no entity reads each unbound role as the total over its members, so no route raises it. It stays as a retired entry, because dev served it before and the spelling stays reserved, and it keeps its Datasets mappings aspin_not_permitteddid, since the schema needs one. The client contract drops itsactions.jsonrow (147 rows).resolution_ambiguousloses its mappings ondatasets.mint,datasets.definitionanddatasets.options, and keepssearch.options.role_incompatiblelosesdatasets.definitionanddatasets.options, andinvalid_role_reflosesdatasets.definition. The definition and options routes admit a definition with no scope, so no scope role refuses there. The routes that raise these codes keep their mappings.Testing: every
tools/validate_*.pypasses, with tools/tests 625, python/spec-kit 450 and python/client-contract 244 passed. dfo-apis tests/platform, tests/datasets_api and tests/contract pass against this tree (5,016).