Repository navigation
Conversation
…pprove in view The plan card refused to shrink in the chat foot (.planWrap flex-shrink: 0, .plan overflow: hidden), so a tall card squeezed the transcript to nothing and the panel clipped the approve bar and the input. The card body now scrolls the way the clarify picker does, the approve bar stays pinned under it, and the transcript keeps a minimum height.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tall plan card in a narrow chat panel left the user stuck: the card did not scroll, the transcript above it shrank to a sliver, and the panel clipped the approve bar and the input, so "View full plan" was the only control in reach. The card sits in the chat foot (
.chatFootinChatPanel.module.scss), which lets a child scroll when it opts in withmin-height: 0; the clarify picker does, the plan card did not (.planWrap { flex-shrink: 0 },.plan { overflow: hidden }inPlanCard.module.scss).The card now opts in the same way.
.planWrapmay shrink,.planscrolls, and the approve bar (.proceed) keeps its size, so Cancel and Approve stay under the card at any panel height..chatScrollkeeps a floor ofrem(88), since with a flex basis of 0 the foot otherwise squeezed the transcript to its padding. A card that fits lays out as before.Testing: tsc, eslint, stylelint and prettier are clean, and
src/lib/studio/test/plan.test.tspasses (112). A static page renderingChatPanelwith a recorded five-step plan, undernext dev, was checked in headless Chrome at a 350 px panel and at 1280 by 640 and 800: before, Approve was clipped or missing; after, the question stays visible, the card scrolls to "View full plan", and Approve and the input stay in view. The 1280 by 800 layout is unchanged.