Repository navigation
chore(deps): vendor the client at sdk 07dba3d - #84
Merged
Merged
Conversation
The client asks the file selector only for its keys and reads nested columns. Shares accept the name_corrected assumption and the view states it as a corrected name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendors the client at sdk
07dba3d(sdk#23), built and re-locked withjust relock-client. The client now asks a version's file selector only forformat,bundleandlayout, so a share whose stored file has expired rebuilds where it raised 400request_invalid. It also reads list and struct columns, refuses invalid base URLs, and names a non-browser runtimeother.The client's types carry the Search API's
name_correctedassumption, with its optionalaskedwording, which dfo-apisdevalready serves.searchShareRequest.tsaccepts it in a stored share (absent or nullasked, else 1 to 200 code points, astext), andassumptionSentenceinview.tsstates it as"Germny" read as Germany.where it fell through to the declared-default sentence.pnpm-lock.yamlchanges the client's integrity hash and carries the re-lock noisedocs/development.mdlists.Testing: lint, CSS lint, typecheck and build pass, and the full suite passes (2,099), with new rows for a corrected name in a share and its sentence.