Repository navigation
Make custom text hyperlinks keyboard and screen-reader accessible - #5461
Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit intoSep 30, 2026
Merged
Conversation
4 tasks done
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused accessibility refactor is consistent across all affected call sites and has no identified correctness issues.
Review effort: Balanced
Findings: None
What changed in this PR
Introduces a reusable, accessible hyperlink-style text control and replaces ad-hoc link implementations.
Changes:
- Adds keyboard, pointer, and screen-reader activation support.
- Standardizes hyperlink styling and behavior.
- Refactors three existing links to use the control.
| File | Description |
|---|---|
General.axaml.cs |
Uses HyperlinkText for the translator link. |
TelemetryDialog.axaml.cs |
Uses HyperlinkText for the legal-details link. |
PackageDetailsWindow.axaml.cs |
Replaces custom hyperlink activation logic. |
HyperlinkText.cs |
Implements reusable hyperlink behavior and automation support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🤖 Pull request was approved automatically: the AI review is complete and all its review threads are resolved. 🎉
Integration Details
{
"deliveryId": "f7815bb0-bcf7-11f1-80d9-9195072ac7ac",
"headSha": "2f65795379adbe29d28d248f9bb4a360dabd08ef",
"reviewer": "copilot-pull-request-reviewer[bot]"
}
Gabriel Dufresne (GabrielDuf)
deleted the
fix/5458-accessible-hyperlinks
branch
September 30, 2026 18:16
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new reusable
HyperlinkTextcontrol to standardize hyperlink-like text behavior throughout the application. The new control handles pointer and keyboard activation, accessibility, and visual styling, replacing previous ad-hoc implementations. Several usages of selectable or clickable text have been refactored to useHyperlinkText, improving code clarity and accessibility.Introduction of
HyperlinkTextcontrol:HyperlinkTextclass insrc/UniGetUI.Avalonia/Views/Controls/HyperlinkText.cs, providing a selectable, keyboard-accessible, and stylized hyperlink text control, including an automation peer for accessibility support.Refactoring usages to use
HyperlinkText:PackageDetailsWindow.axaml.csto useHyperlinkTextinstead ofSelectableTextBlockfor links, removing custom pointer handling logic and attaching activation to the new control'sActivatedevent.TelemetryDialog.axaml.csto useHyperlinkTextin place of a plainTextBlock, simplifying activation and improving accessibility.General.axaml.csto useHyperlinkTextfor the "Become a translator" link, replacing manual pointer event handling with the new control.Code cleanup:
HyperlinkText. [1] [2]These changes improve code maintainability, accessibility, and consistency for hyperlink-like UI elements.