Skip to content

Fix/release sweep queue lock and path broadcast - #5482

Merged
Gabriel Dufresne (GabrielDuf) merged 2 commits into
mainfrom
fix/release-sweep-queue-lock-and-path-broadcast
Oct 7, 2026
Merged

Gabriel Dufresne (GabrielDuf) merged 2 commits into
mainfrom
fix/release-sweep-queue-lock-and-path-broadcast

Conversation

@GabrielDuf

Copy link
Copy Markdown
Contributor

This pull request introduces improvements to the installer script (AddToPath.iss) for better handling of PATH modifications, as well as a minor refactor in the TUI operation registry. The installer now more accurately tracks and logs when the PATH environment variable is changed or when an update fails, and only broadcasts environment changes when necessary. The TUI registry now uses a dedicated method to remove operations from the queue.

Installer script improvements:

  • Added a new boolean variable UnigetPathChanged to track if the PATH was actually modified during installation (AddToPath.iss).
  • Set UnigetPathChanged to True after a successful PATH update, and reset it (along with a new Failed variable) at the start of the update process (AddToPath.iss) [1] [2].
  • Only broadcasts the environment change if the PATH was modified or the update failed, with improved logging and early exit if no changes occurred (AddToPath.iss).
  • Added a local Failed variable to track exceptions during PATH updates (AddToPath.iss).

TUI operation registry refactor:

  • Replaced inline removal loop with a call to the new AbstractOperation.RemoveFromQueue(op) method for cleaner queue management (TuiOperationRegistry.cs).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The changes are focused, consistent with existing behavior, and introduce no identified correctness issues.

Review effort: Balanced
Findings: None

What changed in this PR

Improves installer PATH-change broadcasting and makes TUI queue removal thread-safe.

Changes:

  • Tracks actual PATH modifications and failures before broadcasting environment changes.
  • Uses the synchronized operation queue removal helper.
File Description
InstallerExtras/​AddToPath.iss Conditionally broadcasts PATH environment updates.
src/​UniGetUI.Tui/​Infrastructure/​TuiOperationRegistry.cs Removes queued operations through the lock-protected API.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@randy-but-a-ro randy-but-a-ro Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Pull request was approved automatically: the AI review is complete and all its review threads are resolved. 🎉

Integration Details
{
	"deliveryId": "d0347620-c24f-11f1-9a0e-a31d2e942417",
	"headSha": "a69fa36a8772e0ca59b851d9e713dc18a1a866d7",
	"reviewer": "copilot-pull-request-reviewer[bot]"
}

@GabrielDuf
Gabriel Dufresne (GabrielDuf) merged commit 8ce11bb into main Oct 7, 2026
6 of 7 checks passed
@GabrielDuf
Gabriel Dufresne (GabrielDuf) deleted the fix/release-sweep-queue-lock-and-path-broadcast branch October 7, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants