Repository navigation
Fix/release sweep queue lock and path broadcast - #5482
Merged
Gabriel Dufresne (GabrielDuf) merged 2 commits intoOct 7, 2026
Merged
Gabriel Dufresne (GabrielDuf) merged 2 commits into
Gabriel Dufresne (GabrielDuf) merged 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes are focused, consistent with existing behavior, and introduce no identified correctness issues.
Review effort: Balanced
Findings: None
What changed in this PR
Improves installer PATH-change broadcasting and makes TUI queue removal thread-safe.
Changes:
- Tracks actual PATH modifications and failures before broadcasting environment changes.
- Uses the synchronized operation queue removal helper.
| File | Description |
|---|---|
InstallerExtras/AddToPath.iss |
Conditionally broadcasts PATH environment updates. |
src/UniGetUI.Tui/Infrastructure/TuiOperationRegistry.cs |
Removes queued operations through the lock-protected API. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🤖 Pull request was approved automatically: the AI review is complete and all its review threads are resolved. 🎉
Integration Details
{
"deliveryId": "d0347620-c24f-11f1-9a0e-a31d2e942417",
"headSha": "a69fa36a8772e0ca59b851d9e713dc18a1a866d7",
"reviewer": "copilot-pull-request-reviewer[bot]"
}
Gabriel Dufresne (GabrielDuf)
deleted the
fix/release-sweep-queue-lock-and-path-broadcast
branch
October 7, 2026 15:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the installer script (
AddToPath.iss) for better handling of PATH modifications, as well as a minor refactor in the TUI operation registry. The installer now more accurately tracks and logs when the PATH environment variable is changed or when an update fails, and only broadcasts environment changes when necessary. The TUI registry now uses a dedicated method to remove operations from the queue.Installer script improvements:
UnigetPathChangedto track if the PATH was actually modified during installation (AddToPath.iss).UnigetPathChangedtoTrueafter a successful PATH update, and reset it (along with a newFailedvariable) at the start of the update process (AddToPath.iss) [1] [2].AddToPath.iss).Failedvariable to track exceptions during PATH updates (AddToPath.iss).TUI operation registry refactor:
AbstractOperation.RemoveFromQueue(op)method for cleaner queue management (TuiOperationRegistry.cs).