Skip to content

Feature/macos liquid glass - #5511

Merged
Gabriel Dufresne (GabrielDuf) merged 21 commits into
mainfrom
feature/macos-liquid-glass
Oct 13, 2026
Merged

Gabriel Dufresne (GabrielDuf) merged 21 commits into
mainfrom
feature/macos-liquid-glass

Conversation

@GabrielDuf

Copy link
Copy Markdown
Contributor

This pull request introduces the liquid glasses visual style for the application, providing a more native look and feel on macOS. It adds themed resources, control styles, and initialization logic to enable these styles when running on macOS. Additionally, it expands the English language resources with several common UI terms.

macOS Glass Visual Style Integration

  • Added a new resource dictionary (Styles.MacGlass.axaml and code-behind) defining macOS-specific colors, corner radii, brushes, and theme dictionaries for both light and dark modes, closely matching native macOS vibrancy and control appearance. [1] [2]
  • Introduced a new control styles file (Styles.MacGlassControls.axaml and code-behind) that customizes menus, buttons, toolbars, switches, and other controls for the macOS glass look, including geometry, padding, and icon color behaviors. [1] [2]
  • Updated application initialization in App.axaml.cs to apply these macOS styles when not using Windows Mica, ensuring the correct look is used on each platform.

Localization

  • Extended the English language JSON (lang_en.json) with common UI terms such as "View", "Window", "Zoom", "Undo", "Redo", "Cut", "Copy", "Paste", and "Find" for improved localization coverage.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Hard-coded white foregrounds can produce insufficient contrast with user-selected macOS accent colors.

1 open finding
What changed in this PR

Adds a native-inspired macOS glass theme, platform shortcuts, native menus, and responsive glass layout.

Changes:

  • Adds macOS vibrancy, solid accessibility fallbacks, and themed controls.
  • Introduces macOS menu commands, shortcuts, toolbar grouping, and window layout.
  • Adds English localization keys for native menu actions.
File Description
SoftwareUpdatesPage.cs Groups toolbar actions.
InstalledPackagesPage.cs Groups toolbar actions.
DiscoverSoftwarePage.cs Groups toolbar actions.
AbstractPackagesPage.axaml.cs Uses platform-primary shortcuts.
AbstractPackagesPage.axaml Adds macOS toolbar and list styling.
SidebarView.axaml.cs Adapts accelerator labels.
MainWindow.MacMenu.cs Implements the macOS menu bar.
MainWindow.axaml.cs Adds macOS layout, shortcuts, and clipping.
MainWindow.axaml Adds glass sidebar and window surfaces.
InstallOptionsWindow.axaml.cs Adapts accelerator labels.
ToolbarOverflowPanel.cs Draws grouped toolbar capsules.
SettingsCard.cs Adapts card corners on macOS.
SecureCheckboxCard.cs Styles toggle labels and alignment.
CheckboxCard.cs Styles toggle labels and alignment.
CheckboxButtonCard.cs Styles toggle labels and alignment.
InfoBar.axaml Adds macOS notification styling.
PackagesPageViewModel.cs Supports subgroup separators.
PlatformShortcuts.cs Defines platform shortcut conventions.
MacGlassWindowHelper.cs Manages vibrancy and accessibility fallbacks.
Styles.MacSolid.axaml.cs Loads solid fallback resources.
Styles.MacSolid.axaml Defines solid macOS surfaces.
Styles.MacGlassControls.axaml.cs Loads macOS control styles.
Styles.MacGlassControls.axaml Styles menus, buttons, and toolbars.
Styles.MacGlass.axaml.cs Loads glass resources.
Styles.MacGlass.axaml Defines glass theme resources.
App.axaml.cs Initializes macOS styling.
lang_en.json Adds macOS menu translations.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Shortcut hints and checked-in translation completion metadata remain inconsistent with the new behavior.

0 open findings

1 resolved since last review
Previously missed (2)

In code that hasn't changed since last review

Medium severity Regenerate translated percentage metadata

src/​Languages/​lang_en.json:10

Adding active English keys changes the completion denominator, but the checked-in Languages/Data/TranslatedPercentages.json was not regenerated. The app reads that file directly, so users will continue seeing stale localization percentages; run Sync-TranslationMetadata.ps1 -AllLanguages and include the generated metadata update.

Medium severity Make context-menu shortcut hints platform-aware

src/​UniGetUI.Avalonia/​Views/​SoftwarePages/​AbstractPackagesPage.axaml.cs:484

Switching the handler to the platform primary modifier makes this action ⌘+Enter on macOS, but every package context menu still renders the hard-coded MainActionShortcut = "Ctrl+Enter" hint. Ctrl+Enter no longer invokes the action there, so make the displayed shortcut platform-aware as well.

🧠 Review effort: Balanced

@randy-but-a-ro randy-but-a-ro Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Pull request was approved automatically: the AI review is complete and all its review threads are resolved. 🎉

Integration Details
{
	"deliveryId": "166f8140-c730-11f1-9415-4754b5c88fbe",
	"headSha": "ca46bc284f72f0f88edbe3e9fa9fb81a9d3fb9d1",
	"reviewer": "copilot-pull-request-reviewer[bot]"
}

@GabrielDuf
Gabriel Dufresne (GabrielDuf) merged commit 3fb3d22 into main Oct 13, 2026
7 checks passed
@GabrielDuf
Gabriel Dufresne (GabrielDuf) deleted the feature/macos-liquid-glass branch October 13, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants