Skip to content

Move the Catalog Editor out of the sidebar and behind its own setting - #5587

Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit into
mainfrom
claude/catalog-editor-placement-3083ea
Oct 23, 2026
Merged

Gabriel Dufresne (GabrielDuf) merged 1 commit into
mainfrom
claude/catalog-editor-placement-3083ea

Conversation

@mamoreau-devolutions

Copy link
Copy Markdown
Contributor
  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • Have you confirmed that this issue is caused by UniGetUI itself, and not by the package manager or the package involved?
    If the same issue can be reproduced outside UniGetUI with the relevant package manager or with the package itself, please report it there first. UniGetUI should only be used to track issues that are specific to UniGetUI's behavior or integration.

The Catalog Editor is an administrator tool, but it sat in the main sidebar, where any curious user could open it and edit the deployed catalog. This PR hides it unless an administrator turns it on, and only lets you reach it from the Software Catalog page.

What changes

  • New setting, off by default. "Enable the Catalog Editor" is a new option under Experimental settings → Enable Software Catalog. It is greyed out until the catalog is enabled and, like the catalog setting, needs a restart.
  • Out of the sidebar. The Catalog Editor nav item is removed. If a saved sidebar order includes it, the entry is dropped.
  • Two ways in, both only when the setting is on:
    • a Catalog Editor button in the Software Catalog toolbar, next to Filters and Reload, which opens the editor as it was left;
    • a Create a catalog button in the empty state ("No software catalog has been set up on this device yet."), which opens the editor on a new catalog file.
  • Way back. Any packages page can now show a small "‹ Parent page" link above its title, set through PackagesPageViewModel.ParentPageTitle. Only the Catalog Editor uses it, to link back to Software Catalog.
  • Blank start. The editor opens on an untitled, empty document instead of loading the machine-wide SoftwareCatalog.json, so the deployed catalog is only changed when someone opens it on purpose. Open file, and Save for an untitled document, start in the deployed catalog's folder when that folder exists.
  • Other ways in follow the setting too:
    • "Add selection to catalog" on Discover Packages;
    • the "catalog-editor" startup page;
    • the background API's "catalog-editor" page;
    • direct navigation, which shows a "Catalog Editor is disabled" banner when the setting is off.

Notes for reviewers

  • The editor page's header icon changed from package_managers to catalog_add, to match the toolbar button.
  • PackagesPageViewModel.NoPackagesText is now settable. The editor uses it to say "Create a new catalog or open a catalog file" when no catalog is open.
  • SoftwareCatalogViewModel.EditCommand was never bound to anything. It and its test are removed.
  • New English strings are in lang_en.json. Other languages aren't updated.

Testing

  • All 902 tests in UniGetUI.Tests and 298 in UniGetUI.Core.Language.Tests pass. One full run reported a single failure that did not reproduce on two later runs, and that run did not name the failing test.
  • Updated the sidebar-order tests, and added a test that the editor starts on an untitled document instead of the deployed catalog.
  • Built and ran the app on Windows. The toolbar button, the setting and the editor were checked by hand; the empty-state button and the back link have not been clicked through yet.

🤖 Generated with Claude Code

The Catalog Editor is an administrator tool, but it sat in the main
navigation where any curious user could open it and edit the deployed
catalog. It is now off by default and enabled with a new "Enable the
Catalog Editor" sub-option under Enable Software Catalog.

When enabled, it opens from a Catalog Editor button in the Software
Catalog toolbar, or from Create a catalog on a device with no catalog.
The editor links back to the Software Catalog above its title, and it
starts on an untitled document instead of loading the machine-wide
SoftwareCatalog.json, so the deployed catalog is only edited when an
administrator opens it on purpose.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@GabrielDuf
Gabriel Dufresne (GabrielDuf) merged commit 8765b34 into main Oct 23, 2026
6 checks passed
@GabrielDuf
Gabriel Dufresne (GabrielDuf) deleted the claude/catalog-editor-placement-3083ea branch October 23, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants